-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the timers to track proper DB execution duration. #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lingxiao-microsoft
changed the title
[DRAFT] Fixed the timers to track proper DB execution duration.
Fixed the timers to track proper DB execution duration.
Jan 24, 2025
lingxiao-microsoft
requested review from
Aniruddh25,
aaronburtle,
abhishekkumams,
RubenCerna2079,
ravishetye,
rohkhann,
neeraj-sharma2592,
sourabh1007 and
sezal98
as code owners
January 24, 2025 18:18
rohkhann
approved these changes
Jan 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
JerryNixon
reviewed
Jan 27, 2025
JerryNixon
reviewed
Jan 27, 2025
JerryNixon
reviewed
Jan 27, 2025
JerryNixon
reviewed
Jan 27, 2025
/azp run |
Aniruddh25
reviewed
Jan 29, 2025
Aniruddh25
reviewed
Jan 29, 2025
Aniruddh25
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Left a few comments.
/azp run |
abhishekkumams
approved these changes
Jan 29, 2025
/azp run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Previously we created a PR to add timers to track the duration of DB execution. However, there are some issues within that results in incorrect time duration logged.
Please exclude the whitespaces diff to have a better reviewing experience
ExecuteQueryAsync
, it will invokeExecuteQueryAgainstDbAsync
.We can see the stored value is always twice as the stop watch
What is this change?
ExecuteQueryAsync
andExecuteQuery
ExecuteQueryAgainstDbAsync
andExecuteQueryAgainstDb
try-finally
block to wrap the functions.How was this tested?
Sample Request(s)
ExecuteQueryAsync
level