Creating AzureFirewall with AV Zones quickstart #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomArcherMsft
requested changes
Oct 2, 2023
lonegunmanb
requested changes
Oct 3, 2023
TomArcherMsft
requested changes
Oct 5, 2023
TomArcherMsft
requested changes
Oct 6, 2023
|
@lonegunmanb anything thing else that needs to be changed? |
|
@cshea-msft we should be able to merge this once you fix the e2e test failure. |
|
Hi @cshea-msft thanks for update this pr, I've checked the failed tests, it's not your fault. We use a github action to calculate which folders have been changed by your pr, so if your pr is based on an outdated version of master branch, the test scope would be incorrect. Your pr's base commit is c2ccaa2266a63118c598af8ff67d88391b524308, would you please rebase your pr with the latest master branch and force commit again? Thanks! |
This was referenced Oct 17, 2023
|
Thanks for the update, I updated the branches to sync with the upstream Azure:Master branch.
Charles J Shea
he/him
Senior Engineer
FastTrack for Azure
Office: 518-292-2987
***@***.******@***.***>
[cid:09eee378-94c0-4488-bd35-fbfcf11c12d0]
If you have any feedback about my work, please let either me or my manager Bruno Terakly know at ***@***.******@***.***>
…________________________________
From: lonegunmanb ***@***.***>
Sent: Monday, October 16, 2023 9:47 PM
To: Azure/terraform ***@***.***>
Cc: Charles Shea ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/terraform] Creating AzureFirewall with AV Zones quickstart (PR #252)
Hi @cshea-msft<https://github.com/cshea-msft> thanks for update this pr, I've checked the failed tests, it's not your fault. We use a github action to calculate which folders have been changed by your pr, so if your pr is based on an outdated version of master branch, the test scope would be incorrect. Your pr's base commit is c2ccaa2<https://github.com/Azure/terraform/tree/c2ccaa2266a63118c598af8ff67d88391b524308>, would you please rebase your pr with the latest master branch and force commit again? Thanks!
—
Reply to this email directly, view it on GitHub<#252 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOCDFXQ7YHHVV7DQHYVKTELX7XPRRAVCNFSM6AAAAAA5GOZHN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRVGUZDIOJZHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating another azure firewall quickstarts with AV zones. There is a Bicep and ARM template quickstart for this scenario but not for Terraform.
https://learn.microsoft.com/en-us/azure/firewall/deploy-bicep?tabs=CLI