Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Fleet: panel implementation #1161
base: main
Are you sure you want to change the base?
Create Fleet: panel implementation #1161
Changes from all commits
5316219
a1051c3
fba9774
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be extends BasePanel<"createFleet"> would work, base panel is abstract class that has the basic methods for a panel and data providers which is used for the communication between main extension and webview part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this type refers to the one you have defined it in webviewTypes.ts file @JunyuQian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is typeof contentId going to work?
I don't know typescript well enough to answer that, but syntax wise, typeof contentId looks like it would return a string type, and not the value "createFleet". is that a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering that too, but I think it does make sense with
typeof
. When you look at how the generic type is used, it's matched up to the keys of thisAllWebviewDefinitions
object, which are themselves strings. You can in Typescript define a type which is just a union of string values (e.g. for an enum):So this is doing effectively the same thing as that, just with only a single legal value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TelemetryDefinition<"createFleet"> would work here as well. @JunyuQian similar to the other comment.