Add prettier format check. #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatsinnit
added
enhancement 🚀
Tatsinnit
requested review from
qpetraroia,
ReinierCC,
tejhan and
hsubramanianaks
|
Looks very pretty (lol). 💡 Is it possible to separate the needed changes to get the prettier format check to work and the format changes it would make to the repo? |
tejhan
previously approved these changes
Jan 13, 2025
There was a problem hiding this comment.
The GH action LGTM. 👍
I'm assuming moving forward we will all use the prettier package cleanup before pushing a PR?
Also would a prettier.rc file need to also be added to the repo to ensure PR code is checked for the same formatting rules regardless of who opens one up? (As mentioned in #1162) (Wondering if any slight issue could arise with people using their own local config files)
Tatsinnit
force-pushed
the
add/formatter-check
branch
from
2089c86 to
e8b81da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR take care of this work item: #1162
For now its for thought share for folks.
thanks heaps.