Switch to browser on DUNA redirect URL., Fixes AB#3079799 #2553

p3dr0rv · 2024-12-05T20:50:49Z

In this PR we made the necessary changes to allow the transition from WebView to Browser when a DUNA redirect URL is present. Steps 8 and 9: DUNA flow

At this point ESTS on the WebView will invoke a broker redirect url (msauth://Microsoft.AAD.BrokerPlugin?code=switchBrowserSessionToken&action=switch_browser&action_uri=login.microsoftonline.com/switchbrowser/process)
that will trigger AzureActiveDirectoryWebViewClient to handle the DUNA redirect URL and launch the browser to the switchbrowser/process endpoint

How it works:

If chrome or edge is installed and the SwitchToBrowser client is enabled, then we can declare ourselves DUNA capable. see: broker related PR

If ESTS calls a broker redirect URL for DUNA AzureActiveDirectoryWebViewClient will handle the DUNA redirect URL and use EmbeddedWebViewAuthorizationStrategy to launch the browser to the switchbrowser/process endpoint. (this PR)

Main Changes:

BrowserSelector is now part of the PlatformComponents
The AndroidAuthorizationStrategyFactory signature changed:
- Before: getAuthorizationStrategy(InteractiveTokenCommandParameters parameters);
- After: getAuthorizationStrategy(AuthorizationAgent authorizationAgent, Browser browser, boolean isBrokerRequest);
- The AndroidAuthorizationStrategyFactory
Add unit tests for validation.

AB#3079799

github-actions · 2024-12-05T20:51:05Z

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

github-actions · 2024-12-07T00:53:41Z

✅ Work item link check complete. Description contains link AB#3079799 to an Azure Boards work item.

common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java

…D/microsoft-authentication-library-common-for-android into pedroro/switch-to-browser

common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java

common/src/main/java/com/microsoft/identity/common/internal/broker/BrokerRequest.java

...n/src/main/java/com/microsoft/identity/common/internal/request/MsalBrokerRequestAdapter.java

...ava/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java

common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java

...va/com/microsoft/identity/common/internal/providers/oauth2/AuthorizationActivityFactory.java

...om/microsoft/identity/common/internal/ui/webview/challengehandlers/SwitchBrowserUriHelper.kt

common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java

...ava/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java

...om/microsoft/identity/common/internal/ui/webview/challengehandlers/SwitchBrowserChallenge.kt

...om/microsoft/identity/common/internal/ui/webview/challengehandlers/SwitchBrowserUriHelper.kt

…al/AuthenticationConstants.java Co-authored-by: Shahzaib <[email protected]>

...om/microsoft/identity/common/internal/ui/webview/challengehandlers/SwitchBrowserUriHelper.kt

...ava/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java

…/webview/AzureActiveDirectoryWebViewClient.java Co-authored-by: Shahzaib <[email protected]>

…D/microsoft-authentication-library-common-for-android into pedroro/switch-to-browser

shahzaibj · 2025-02-20T16:59:01Z

...ava/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java

+            if (throwable instanceof IErrorInformation) {
+                errorCode = ((IErrorInformation) throwable).getErrorCode();
+            } else {
+                errorCode = MALFORMED_URL;


If we ever get here then is it guaranteed to always be a case of malformed url? We are catching generic throwable so I'm not sure if that's always the case

changing error code

shahzaibj · 2025-02-20T17:02:19Z

.../com/microsoft/identity/common/internal/ui/webview/challengehandlers/SwitchBrowserHandler.kt

+            BrowserDescriptor.getBrowserSafeListForSwitchBrowser(),
+            null
+        )
+        if (browser == null) {


Is this a case of browser being uninstalled between the time interactive request started and got to this point? I'm asking because I see we already check for browser being available even before we declare switch browser capable

Yes, at this point we expect the browser not to be null as we check prior to initiate DUNA, but because the function can return null, we do this check

...om/microsoft/identity/common/internal/ui/webview/challengehandlers/SwitchBrowserUriHelper.kt

shahzaibj · 2025-02-20T17:08:46Z

...icrosoft/identity/common/internal/ui/webview/challengehandlers/SwitchBrowserUriHelperTest.kt

+        val exception = Assert.assertThrows(ClientException::class.java) {
+            SwitchBrowserUriHelper.buildProcessUri(redirectUri)
+        }
+        Assert.assertEquals(ClientException.MALFORMED_URL, exception.errorCode)


Let's also assert the error message

…/webview/challengehandlers/SwitchBrowserUriHelper.kt Co-authored-by: Shahzaib <[email protected]>

p3dr0rv added 5 commits December 3, 2024 10:52

draft

560d0fb

draft 2

7632017

nits

f30b5bc

nits

82251aa

javadoc

e7636cb

p3dr0rv added 2 commits December 5, 2024 13:59

Merge branch 'dev' into pedroro/switch-to-browser

a8720b9

add tests

ca4f0eb

p3dr0rv changed the title ~~[WIP] Switch to browser on DUNA redirect URL.~~ Switch to browser on DUNA redirect URL. Dec 7, 2024

github-actions bot changed the title ~~Switch to browser on DUNA redirect URL.~~ Switch to browser on DUNA redirect URL., Fixes AB#3079799 Dec 7, 2024

p3dr0rv marked this pull request as ready for review December 7, 2024 00:55

p3dr0rv requested a review from a team as a code owner December 7, 2024 00:55

shahzaibj reviewed Dec 7, 2024

View reviewed changes

common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java Outdated Show resolved Hide resolved

shahzaibj reviewed Dec 7, 2024

View reviewed changes

common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java Outdated Show resolved Hide resolved

p3dr0rv and others added 9 commits December 6, 2024 17:15

update names

19e0498

fix tests

76155d9

Refactor startActivity call in WebViewAuthorizationFragment

a389026

Add redirect URI query parameter

6178335

create snippets

744d212

Merge branch 'dev' into pedroro/switch-to-browser

e3da415

update tests

d569aa6

Merge branch 'pedroro/switch-to-browser' of https://github.com/AzureA…

c404af1

…D/microsoft-authentication-library-common-for-android into pedroro/switch-to-browser

Merge branch 'dev' into pedroro/switch-to-browser

9385aba

shahzaibj reviewed Dec 17, 2024

View reviewed changes

common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java Outdated Show resolved Hide resolved

shahzaibj reviewed Dec 17, 2024

View reviewed changes

common/src/main/java/com/microsoft/identity/common/internal/broker/BrokerRequest.java Outdated Show resolved Hide resolved

shahzaibj reviewed Dec 17, 2024

View reviewed changes

...n/src/main/java/com/microsoft/identity/common/internal/request/MsalBrokerRequestAdapter.java Outdated Show resolved Hide resolved

shahzaibj reviewed Dec 17, 2024

View reviewed changes

...ava/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java Outdated Show resolved Hide resolved

p3dr0rv added 2 commits December 17, 2024 18:43

used defined browsers for duna flow

58c771c

feedback

fae212f

p3dr0rv added 3 commits January 28, 2025 15:41

add SwitchBrowserUriHelper

b0343eb

update constants

914856b

license

9ea834a

shahzaibj reviewed Feb 13, 2025

View reviewed changes

common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java Outdated Show resolved Hide resolved

shahzaibj reviewed Feb 13, 2025

View reviewed changes

...va/com/microsoft/identity/common/internal/providers/oauth2/AuthorizationActivityFactory.java Outdated Show resolved Hide resolved

shahzaibj reviewed Feb 13, 2025

View reviewed changes

...om/microsoft/identity/common/internal/ui/webview/challengehandlers/SwitchBrowserUriHelper.kt Outdated Show resolved Hide resolved

shahzaibj reviewed Feb 13, 2025

View reviewed changes

...om/microsoft/identity/common/internal/ui/webview/challengehandlers/SwitchBrowserUriHelper.kt Outdated Show resolved Hide resolved

p3dr0rv added 5 commits February 18, 2025 16:26

remove action

15511ee

Merge branch 'dev' into pedroro/switch-to-browser

ceeb3f0

Update SwitchBrowserUriHelper.kt

d8c2d4e

update flag

2e47d40

update test

75b14e6