fix: fix slice init length (GoogleCloudPlatform#11919)

BBBmau · Nov 5, 2024 · 5c20337 · 5c20337
1 parent 5835fa7
commit 5c20337
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/mmv1/templates/terraform/unordered_list_customize_diff.erb b/mmv1/templates/terraform/unordered_list_customize_diff.erb
@@ -14,8 +14,8 @@ if oldCount.(int) < newCount.(int) {
 if count < 1 {
     return nil
 }
-old := make([]interface{}, count)
-new := make([]interface{}, count)
+old := make([]interface{}, 0, count)
+new := make([]interface{}, 0, count)
 for i := 0; i < count; i++ {
     o, n := diff.GetChange(fmt.Sprintf("<%= prop.name.underscore -%>.%d", i))
 

diff --git a/mmv1/templates/terraform/unordered_list_customize_diff.go.tmpl b/mmv1/templates/terraform/unordered_list_customize_diff.go.tmpl
@@ -15,8 +15,8 @@ if oldCount.(int) < newCount.(int) {
 if count < 1 {
     return nil
 }
-old := make([]interface{}, count)
-new := make([]interface{}, count)
+old := make([]interface{}, 0, count)
+new := make([]interface{}, 0, count)
 for i := 0; i < count; i++ {
     o, n := diff.GetChange(fmt.Sprintf("{{ underscore $.Name }}.%d", i))
 

diff --git a/mmv1/third_party/terraform/services/compute/metadata.go.tmpl b/mmv1/third_party/terraform/services/compute/metadata.go.tmpl
@@ -96,7 +96,7 @@ func BetaMetadataUpdate(oldMDMap map[string]interface{}, newMDMap map[string]int
 }
 
 func expandComputeMetadata(m map[string]interface{}) []*compute.MetadataItems {
-	metadata := make([]*compute.MetadataItems, len(m))
+	metadata := make([]*compute.MetadataItems, 0, len(m))
 	var keys []string
 	for key := range m {
 		keys = append(keys, key)

diff --git a/tpgtools/ignored_handwritten/common_custom_diff.go b/tpgtools/ignored_handwritten/common_custom_diff.go
@@ -44,8 +44,8 @@ func resourceComputeSubnetworkSecondaryIpRangeSetStyleDiff(diff *schema.Resource
 	if count < 1 {
 		return nil
 	}
-	old := make([]interface{}, count)
-	new := make([]interface{}, count)
+	old := make([]interface{}, 0, count)
+	new := make([]interface{}, 0, count)
 	for i := 0; i < count; i++ {
 		o, n := diff.GetChange(fmt.Sprintf("secondary_ip_range.%d", i))