Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[동방 예약] 보조선 추가 #154

Merged
merged 3 commits into from
Apr 5, 2024
Merged

[동방 예약] 보조선 추가 #154

merged 3 commits into from
Apr 5, 2024

Conversation

dooohun
Copy link
Contributor

@dooohun dooohun commented Apr 2, 2024

[#127] request

  • 동방 예약 시 보조선을 1시간 단위로 추가했습니다.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Did you merge recent main branch?

Screenshot

image

Precautions (main files for this PR ...)

@dooohun dooohun added the bug Something isn't working label Apr 2, 2024
@dooohun dooohun self-assigned this Apr 2, 2024
chaeseungyun
chaeseungyun approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@chaeseungyun chaeseungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

현재 /query/reservation.ts에 있는 useDeleteReservations의 onError 부분에서
스낵바의 message 부분에 data를 보여주고 있어요
이 부분을 data.message로 수정하고 머지하면 될 것 같아요

@dooohun
Copy link
Contributor Author

dooohun commented Apr 5, 2024

@chaeseungyun 해당 내용 수정 완료했습니다! ce7f0d1

@dooohun dooohun merged commit 1f427a2 into main Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChoiWonBeen ChoiWonBeen ChoiWonBeen approved these changes

@MinGu-Jeong MinGu-Jeong MinGu-Jeong approved these changes

@chaeseungyun chaeseungyun chaeseungyun approved these changes

@hanagertrudeKim hanagertrudeKim Awaiting requested review from hanagertrudeKim hanagertrudeKim is a code owner

Assignees

@dooohun dooohun

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[동방 예약] 시간 선택할 때 보조선이 있으면 좋겠어요 (예측샷해야함..)
4 participants
@dooohun @ChoiWonBeen @MinGu-Jeong @chaeseungyun