[Feature] 버튼 디자인 시스템 구축 (모듈화) #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wnehdals
reviewed
Feb 20, 2024
jj_design/src/main/java/com/android/jj_design/button/JjChipButton.kt
Outdated
Show resolved
Hide resolved
wnehdals
reviewed
Feb 20, 2024
| context: Context, | ||
| attributeSet: AttributeSet? = null, | ||
| defStyleAttr: Int = 0, | ||
| ) : AppCompatButton(context, attributeSet, defStyleAttr) { |
There was a problem hiding this comment.
LinearLayout 혹은 ConstraintLayout 상속받는걸로 변경해주세요
wnehdals
reviewed
Feb 20, 2024
jj_design/src/main/java/com/android/jj_design/button/JjButton.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 개요
이슈 번호: #168
작업사항
시연영상
339a033a-2aba-40cc-84b8-717cbf6b50d7.mp4