-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using BatchRequest for Pulls #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vietle-bh , I've done a quick commit to solve the problem highlighted above: Not sure if the 'OriginalRequest' property was really necessary but I thought it was better to be safe than sorry. |
Thanks @adecler ! That 'OriginalRequest' property is actually perfect. I previously had to include the worksheet name in each Excel tab in order to divide the flat result from batch Pull back into sublists, one per original request. It's much easier to use now after your addition 🙌 |
@vietle-bh to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as intended. Now that the output is clustered by request, I am happy with the code.
@BHoMBot check ready-to-merge |
@adecler to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #89
The change allowed me to use
BatchRequest
for pulling from multiple worksheets without reopening the workbook.I'm a complete newbie in this repo 😅but hope this is good enough for a merge!
Test files
TestBatchPulling.zip
Changelog
Additional comments