Draft: Gl 1455 user mapping #2009
Conversation
To be used in the connect function of AS
|
In GitLab by @dbeltrankyl on Nov 21, 2024, 16:02 There is nothing implemented ( the current part implemented is half done ) but I've written the docs of how it works etc. if you want to take a look @kinow , @mcastril |
|
In GitLab by @kinow on Nov 22, 2024, 09:11 Commented on docs/source/userguide/user_mapping.rst line 15 s/hpc/HPC |
|
In GitLab by @kinow on Nov 22, 2024, 09:11 Commented on docs/source/userguide/user_mapping.rst line 17 s/More specifically, this is useful to launch/This can be useful to launch something like an experiment testing suite/ ? Otherwise, it may sound strange to those that never heard of the testing suite (closed source for now). |
|
In GitLab by @kinow on Nov 22, 2024, 09:11 Commented on docs/source/userguide/user_mapping.rst line 19 prerequisites? https://www.dictionary.com/browse/prerequisite, https://learn.microsoft.com/en-us/mem/configmgr/sum/plan-design/prerequisites-for-software-updates |
|
In GitLab by @kinow on Nov 22, 2024, 09:11 Commented on docs/source/userguide/user_mapping.rst line 8 s/User/user, s/personal users account/personal user accounts/ ? or user's... but I think we don't need the apostrophe+s |
|
In GitLab by @kinow on Nov 22, 2024, 09:11 Commented on docs/source/userguide/user_mapping.rst line 10 s/is personal account/is the account used ? |
|
In GitLab by @kinow on Nov 22, 2024, 09:11 Commented on docs/source/userguide/user_mapping.rst line 24 responsible for? of is normally someone or a place, I think? https://ell.stackexchange.com/questions/85823/responsible-of-vs-responsible-for |
|
In GitLab by @kinow on Nov 22, 2024, 09:11 Commented on docs/source/userguide/user_mapping.rst line 26 s/reponsable/responsible, and s/of not/for not... Although I think we can rewrite as "The user is responsible for keeping their personal user account details (e.g. SSH keys) secure, e.g. not sharing it with other users. ? |
|
In GitLab by @kinow on Nov 22, 2024, 09:11 Commented on docs/source/userguide/user_mapping.rst line 28 s/platform_${SUDO_USER}.yml/ |
|
In GitLab by @kinow on Nov 22, 2024, 09:11 @dbeltrankyl great idea to write the docs first (I think we can do the same with a pytest test for future tasks that involve code that we are still discussing, maybe with some prototype code to show how it'd work). I will read the rest later today/Monday. I did some tests with Paramiko yesterday and I think I understand what Henrik said. I will reply on the other issue too, but it seems this might be really the best approach and that we might as well include a note in our docs about SSH config |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 09:28 Thanks Bruno!
That was the idea, since we discussed it in the AS meeting, yesterday I rushed the docs to not forget what we discussed I did not expect you to review phrase per phrase, yet I was asking more about opinions about its content/structure and if it was easy to understand from the user's point of view Thanks for the review! I wanted to rewrite some stuff today as it was rushed yesterday, but I will take your feedback as well. |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 09:31 Commented on docs/source/userguide/user_mapping.rst line 17 Yes, that was my intention but failed, your approach seems better, thanks! |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 09:33 Commented on docs/source/userguide/user_mapping.rst line 10 Oops, that phrase was left a mess, thanks |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 09:36 Commented on docs/source/userguide/user_mapping.rst line 15 changed this line in version 2 of the diff |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 09:36 Commented on docs/source/userguide/user_mapping.rst line 17 changed this line in version 2 of the diff |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 09:36 Commented on docs/source/userguide/user_mapping.rst line 19 changed this line in version 2 of the diff |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 09:36 Commented on docs/source/userguide/user_mapping.rst line 8 changed this line in version 2 of the diff |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 09:36 Commented on docs/source/userguide/user_mapping.rst line 10 changed this line in version 2 of the diff |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 09:36 Commented on docs/source/userguide/user_mapping.rst line 24 changed this line in version 2 of the diff |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 09:36 Commented on docs/source/userguide/user_mapping.rst line 26 changed this line in version 2 of the diff |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 09:36 Commented on docs/source/userguide/user_mapping.rst line 28 changed this line in version 2 of the diff |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 09:36 added 1 commit
|
|
In GitLab by @kinow on Nov 22, 2024, 09:42 That's alright. I was reviewing because I had a quick read of everything (to get the idea) and this seems like the way forward :slight_smile: i.e. I think we can use these docs to understand what'll be done, and then add code & merge it by next week for 4.1.12 (workflow devs will be thrilled when this gets ready!). Thanks!!! |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 10:00 added 1 commit
|
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 12:38 added 1 commit
|
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 12:48 marked the checklist item Implement the related Asconfig parser ( and implement the AS config parser code ) # related to: TODO as completed |
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 15:48 added 1 commit
|
|
In GitLab by @dbeltrankyl on Nov 22, 2024, 15:50 added 1 commit
|
|
In GitLab by @dbeltrankyl on Nov 25, 2024, 13:05 added 1 commit
|
|
In GitLab by @dbeltrankyl on Nov 25, 2024, 13:06 added 11 commits
|
|
In GitLab by @dbeltrankyl on Nov 25, 2024, 13:06 marked the checklist item Implement the related part as completed |
|
In GitLab by @dbeltrankyl on Nov 25, 2024, 13:06 marked the checklist item Pytest as completed |
|
In GitLab by @dbeltrankyl on Nov 25, 2024, 13:06 resolved all threads |
|
In GitLab by @dbeltrankyl on Nov 25, 2024, 13:07 Rebased, fixed the function as it had some flaws, and added pytest for it.
|
|
In GitLab by @dbeltrankyl on Nov 25, 2024, 13:08 It also needs to have BSC-ES/autosubmit-config-parser#54 this merged Once merged, I have to update the setup.py to match the asconfigparser version |
|
In GitLab by @dbeltrankyl on Nov 25, 2024, 14:34 added 1 commit
|
|
In GitLab by @dbeltrankyl on Nov 29, 2024, 14:41 added 1 commit
|
|
In GitLab by @dbeltrankyl on Nov 29, 2024, 16:07 marked the checklist item Merge and update Asconfigparser version BSC-ES/autosubmit-config-parser#54 as completed |
In GitLab by @dbeltrankyl on Nov 21, 2024, 16:02