GH-2065: Correct join character for jobs in wrapper (was &, is now _) #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
force-pushed
the
fix-2065-join-character
branch
from
10c1caa to
4a32910
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2066 +/- ##
=======================================
Coverage 48.92% 48.92%
=======================================
Files 72 72
Lines 17541 17541
Branches 3415 3415
=======================================
Hits 8582 8582
Misses 8154 8154
Partials 805 805
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Quick/easy one, thanks for the hints on where/what to fix, @dbeltrankyl . Ready for review. |
|
Hello @kinow I think we can merge it, sorry the delay I was focused on the tests for the wallclock issue Thanks |
dbeltrankyl
approved these changes
Jan 17, 2025
|
Thanks Dani! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2065
It's pending that I write a test that fails if we ever change it, accidentally, again to
&.