Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limited concurrency in tests, changed swabbing in schema and utils.read_excel() #261

Merged
merged 6 commits into from
May 20, 2024
Merged

Limited concurrency in tests, changed swabbing in schema and utils.read_excel() #261

merged 6 commits into from
May 20, 2024

Conversation

Shettland
Copy link
Member

This is a small PR with various functionality improvementes.

  • I limited concurrency in sftp-handle tests to avoid crashing
  • I changed swabbing for swab in relecov-schema.json and anatomical_material_collection_method.json so the names resembles the one in the ontology better.
  • Finally I changed read_excel_file() in utils.py so it searches for a header flag instead of hardcoding a row

saramonzon
saramonzon approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@saramonzon saramonzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect for me! Keep them coming!

@Shettland Shettland merged commit a283e35 into BU-ISCIII:develop May 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saramonzon saramonzon saramonzon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shettland @saramonzon