Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "options" interpretation in build-schema and update read-lab-metadata field type #388

Merged
merged 8 commits into from
Feb 12, 2025
Merged

Improve "options" interpretation in build-schema and update read-lab-metadata field type #388

merged 8 commits into from
Feb 12, 2025
+62 −27

Conversation

Aberdur
Copy link
Contributor

@Aberdur Aberdur commented Feb 11, 2025

PR description

This PR improves build-schema and read-lab-metadata modules:

  • Implemented interpretation of "options" column in orther to add this fields to its property.
  • Enhanced field typing while creating lab_metadata json on read-lab-metadata-module

@Daniel-VM Daniel-VM self-requested a review February 11, 2025 12:53
@Aberdur Aberdur marked this pull request as draft February 11, 2025 13:53
@Aberdur Aberdur marked this pull request as ready for review February 12, 2025 07:42
Daniel-VM
Daniel-VM reviewed Feb 12, 2025
View reviewed changes
Copy link
Member

@Daniel-VM Daniel-VM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single comment to address, and you're ready.

relecov_tools/read_lab_metadata.py Outdated Show resolved Hide resolved
@Daniel-VM Daniel-VM merged commit 23aad9f into BU-ISCIII:develop Feb 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel-VM Daniel-VM Daniel-VM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aberdur @Daniel-VM