Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance validation of database definitinon values #389

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

Daniel-VM
Copy link
Member

PR Description

This PR improves the validate_database_definition method with several enhancements to ensure better schema validation and error reporting:

Major improvements

  • Checks for duplicated enums
  • Checks for date format complance
  • Generates a structured error report and saves it in csv

Related (#381 )

Aberdur
Aberdur previously approved these changes Feb 12, 2025
Copy link
Contributor

@Aberdur Aberdur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aberdur Aberdur dismissed their stale review February 12, 2025 10:42

Not updated CHANGELOG

@Daniel-VM Daniel-VM merged commit ad66d43 into BU-ISCIII:develop Feb 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants