Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the app to run on tethys4 #5

Open
wants to merge 18 commits into
base: interpolation_debug
Choose a base branch
from

Conversation

EricJJones
Copy link

Co-authored-by: Nathan Swain [email protected]

@swainn
Copy link

swainn commented Jun 23, 2022

@SarvaPulla this is ready for your review. It's still marked as a draft PR b/c I can't change the status of the PR. So if you could change that that would be great.

If you install the dev version of Tethys Platform, that will be the latest version of Tethys 4 (though it will call the version 3.4.1.devXXXX). Then you can install this version of gwdm and verify that it is functioning properly.

@EricJJones EricJJones marked this pull request as ready for review June 23, 2022 15:45
@EricJJones EricJJones changed the title WIP: Upgrade the app to run on tethys4 Upgrade the app to run on tethys4 Jun 23, 2022
@SarvaPulla
Copy link
Collaborator

@EricJJones and @swainn everything looks good except for one minor issue. Could you please replace the hidden class with the new d-none class of Boostrap 5? I would take the vendor directory in the public folder out so it's easier to do a find and replace on the remaining html, js, and a couple of py files. I have tested everything else and it's working fine.

@swainn
Copy link

swainn commented Jul 21, 2022

@EricJJones and @swainn everything looks good except for one minor issue. Could you please replace the hidden class with the new d-none class of Boostrap 5? I would take the vendor directory in the public folder out so it's easier to do a find and replace on the remaining html, js, and a couple of py files. I have tested everything else and it's working fine.

Will do.

@swainn
Copy link

swainn commented Jul 21, 2022

@EricJJones and @swainn everything looks good except for one minor issue. Could you please replace the hidden class with the new d-none class of Boostrap 5? I would take the vendor directory in the public folder out so it's easier to do a find and replace on the remaining html, js, and a couple of py files. I have tested everything else and it's working fine.

This is done @SarvaPulla can you please verify?

@rileyhales
Copy link
Member

@swainn @msouff please coordinate with @njones61 and sergio, sarva, or others before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants