-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the app to run on tethys4 #5
base: interpolation_debug
Are you sure you want to change the base?
Upgrade the app to run on tethys4 #5
Conversation
Co-authored-by: Nathan Swain <[email protected]>
afa5bab
to
3ff44ef
Compare
@SarvaPulla this is ready for your review. It's still marked as a draft PR b/c I can't change the status of the PR. So if you could change that that would be great. If you install the dev version of Tethys Platform, that will be the latest version of Tethys 4 (though it will call the version 3.4.1.devXXXX). Then you can install this version of gwdm and verify that it is functioning properly. |
@EricJJones and @swainn everything looks good except for one minor issue. Could you please replace the hidden class with the new d-none class of Boostrap 5? I would take the vendor directory in the public folder out so it's easier to do a find and replace on the remaining html, js, and a couple of py files. I have tested everything else and it's working fine. |
Will do. |
This is done @SarvaPulla can you please verify? |
0d265af
to
d31e289
Compare
Co-authored-by: Nathan Swain [email protected]