-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding benchmarks with Criterion #31
Draft
Laifsyn
wants to merge
53
commits into
Ballasi:master
Choose a base branch
from
Laifsyn:branch2-of-main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Lang enum should be really small since it doesn't contain any inherent data. So it should be dirt cheap to copy
This should probably be the snippet of interest //8GB RAM 2-cores Codespace
English time: [159.08 µs 161.34 µs 163.93 µs]
Found 14 outliers among 100 measurements (14.00%)
4 (4.00%) high mild
10 (10.00%) high severe
French time: [157.37 µs 159.43 µs 161.73 µs]
Found 18 outliers among 100 measurements (18.00%)
6 (6.00%) high mild
12 (12.00%) high severe
French_BE time: [157.24 µs 159.91 µs 163.33 µs]
Found 16 outliers among 100 measurements (16.00%)
3 (3.00%) high mild
13 (13.00%) high severe
French_CH time: [157.60 µs 159.73 µs 162.13 µs]
Found 18 outliers among 100 measurements (18.00%)
11 (11.00%) high mild
7 (7.00%) high severe
Spanish time: [17.792 µs 18.141 µs 18.551 µs]
Found 15 outliers among 100 measurements (15.00%)
2 (2.00%) high mild
13 (13.00%) high severe
Ukrainian time: [158.49 µs 160.56 µs 162.99 µs]
Found 19 outliers among 100 measurements (19.00%)
6 (6.00%) high mild
13 (13.00%) high severe |
* Fix Tens edge case for Ordinals based on [Real Academia Española](https://www.rae.es/dpd/ordinales) standards, the TENS of 2 have no space between itself and its units. `"la primera y a la segunda decena se pueden escribir en una o en dos palabras, siendo hoy mayoritaria y siempre preferible la grafía univerbal"` * Fix Ordinals Representation From Ballasi#29 (comment), fix ordinal representation based on the rules defined in 2.b && 2.d @ https://www.rae.es/dpd/ordinales * Fix Tests & remove comments * Currency Translation for spanish * Cardinal Fix - Mistakenly used English semantics (#1) Fix the wrong semantics that was used. Spanish semantics follows this pattern of for each big milliard (Million, Billion, Trillion) grows at a pace of `1 000 000`^n This means that 1 million is `1 000 000`^1 1 billion => `1 000 000`^2 [1 000_000 000_000] 1 trillion => `1 000 000`^3 [1 000_000 000_000 000_000] 1 quadrillion => `1 000 000`^4 [......] ...... etc This semantic differs from english's 1 billion => `1 000`^3 [1 000 000_000] 1 trillion => `1 000 000`^4 [1 000_000 000_000] 1 quadrillion => `1 000 000`^4 [......]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.