Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw when forta attestation falis #640

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

0xsambugs
Copy link
Contributor

We will now throw when the forta attestation fails. Before this change, we would continue with an invalid JSON, leading to other issues that were difficult to debug

@0xsambugs 0xsambugs self-assigned this Jan 8, 2025
@0xsambugs 0xsambugs requested a review from 0xKoaj January 8, 2025 18:28
Copy link
Contributor

@0xKoaj 0xKoaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@0xsambugs 0xsambugs merged commit 585c774 into feat/earn Jan 8, 2025
2 of 3 checks passed
@0xsambugs 0xsambugs deleted the fix/throw-when-forta-attestation-fails branch January 8, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants