Score cli #1
Score cli #1
Conversation
| repo (get-in event ["repo" "name"]) | ||
| action (get-in event ["payload" "action"]) | ||
| date (get event "created_at")] | ||
| (if (= type "PullRequestEvent") |
There was a problem hiding this comment.
@lordaniel if will return a bloq with nil and it is ugly, use when when you only care for the first part of the body
| action (get-in event ["payload" "action"]) | ||
| date (get event "created_at")] | ||
| (if (= type "PullRequestEvent") | ||
| (if (.startsWith date "2016-10") |
There was a problem hiding this comment.
Same here, and actually you can use only one conditional something like (and (= type ...) (.start....))
| date (get event "created_at")] | ||
| (if (= type "PullRequestEvent") | ||
| (if (.startsWith date "2016-10") | ||
| (hash-map :actor actor :repo repo :date date))))) |
There was a problem hiding this comment.
you can replace (hash-map :actor actor ...) with {:actor actor ...}
| (hash-map :actor actor :repo repo :date date))))) | ||
|
|
||
| (defn clean-arr [arr] | ||
| (loop [init arr |
|
|
||
| (defn count-pr [arr-pr] | ||
| (if (> (count arr-pr) 0) | ||
| {:user (get (first arr-pr) :actor) :score (count arr-pr) :lastpr (get (first arr-pr) :date)})) |
There was a problem hiding this comment.
a very neat trick when using keyword (those that start with :) in clojure is that they can be used as a functions to get the val so (get (first arr-pr) :actor) should be (:actor (first arr-r))
| (println "User - Score") | ||
| (apply println (map (fn [m] (str "\n" (get m :user) " - " (get m :score))) | ||
| (sort-by :score > (filter (fn [x] (> (count x) 0)) | ||
| (map count-pr (map clean-arr (map (fn [arr] (map get-pullrequest arr)) |
|
|
||
| (defn count-user-pr [arr] | ||
| (loop [[h & t] arr prs '()] | ||
| (if (empty? h) |
| (if (> (count prs) 0) | ||
| {:user (:actor (first prs)) :score (count prs) :last (:date (last prs))}) | ||
| (recur t (if (and (= (get h "type") "PullRequestEvent") (.startsWith (get h "created_at") "2016-10")) | ||
| (conj prs {:actor (get-in h ["actor" "login"]) :repo (get-in h ["repo" "name"]) :date (get h "created_at")}) |
There was a problem hiding this comment.
maybe some destructuring within h definition will help, something like [[{type "type date "created_at" {name "name"} "repo" {login "login"} "actor"} & t] arr prs '()]
There was a problem hiding this comment.
an initial observation here, is that when you build something with loop to fill a collection with a tail recursion like this, it is 'manual' reduce, this should be refactored into a reduce
| {:user (get (first arr-pr) :actor) :score (count arr-pr) :lastpr (get (first arr-pr) :date)})) | ||
|
|
||
| (defn count-user-pr [arr] | ||
| (loop [[h & t] arr prs '()] |
There was a problem hiding this comment.
What are h, t and arr?
What about more descriptive names?
There was a problem hiding this comment.
@caipivara I guess that:
h -> head.
t -> Tail.
arr -> Array
|
Still waiting on the reduce refactor |
| "Count User Pull Request Events" | ||
| (reduce (fn [final-prs pr] | ||
| (let [{type "type" date "created_at" {name "name"} "repo" {login "login"} "actor"} pr] | ||
| (if (and (= type "PullRequestEvent") (.startsWith date "2016-10")) |
There was a problem hiding this comment.
October is hardcoded, what if you make the date an argument?
| (defn count-user-pr [user-events] | ||
| "Count User Pull Request Events" | ||
| (reduce (fn [final-prs pr] | ||
| (let [{type "type" date "created_at" {name "name"} "repo" {login "login"} "actor"} pr] |
There was a problem hiding this comment.
this let could be avoided if you do some destructuring at function signature
| {:user login :score 1 :last date} | ||
| (assoc final-prs :score (inc (:score final-prs)))) | ||
| final-prs))) | ||
| '() |
There was a problem hiding this comment.
what if you apply a PullRequestEvent+Date filter first?
That way the reduce will get only PullRequests within the date range, making the internal function simpler
Finish working-skeleton for Score bot supporting parameters (org-name and token)