fix: delete position type inconnue #496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaGOs92
approved these changes
Jan 9, 2025
| `ALTER TABLE "positions" ALTER COLUMN "type" TYPE "public"."positions_type_enum_old" USING "type"::"text"::"public"."positions_type_enum_old"`, | ||
| ); | ||
| await queryRunner.query( | ||
| `ALTER TABLE "positions" ALTER COLUMN "type" SET DEFAULT 'entrée'`, |
There was a problem hiding this comment.
pour le down, il faudrait set le default à "inconnue"
There was a problem hiding this comment.
ça me parait compliqué toutes ces manipulations de l'enum... Y'a pas juste moyen de supprimer / ajouter une valeur dans l'enum?
There was a problem hiding this comment.
| clock: yarn start:cron |
There was a problem hiding this comment.
On pourrait pas se servir d'une variable d'env pour lancer les migrations en mode auto ou non?
Je vois dans la doc de Scalingo qu'on peut faire ce genre de chose : https://doc.scalingo.com/platform/app/procfile
Le Procfile :
clock: yarn start:cron
postdeploy: bash bin/postdeploy.sh
et le script postdeploy.sh =>
#!/bin/bash
if [ "$LAUNCH_MIGRATION_AT_START" = "true" ] ; then
exec yarn typeorm:migration:run
fi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTEXT
Le type de position
inconnuene passe pas le validateurIl faut retirer la possibilité d'utiliser le type de position
inconnuedans l'application mes-adressesFONCTIONNALITE
entréepar default a l'importPR