Popup new bal already exist #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fufeck
changed the title
fufeck
force-pushed
the
fufeck_feat_popup-new-bal-already-exist
branch
from
cc223a6 to
8094d3e
Compare
MaGOs92
reviewed
Jan 26, 2024
components/new/alert-published-bal/alert-puslished-bal-api-depot.tsx
Outdated
Show resolved
Hide resolved
components/new/alert-published-bal/alert-puslished-bal-api-depot.tsx
Outdated
Show resolved
Hide resolved
components/new/alert-published-bal/alert-puslished-bal-api-depot.tsx
Outdated
Show resolved
Hide resolved
MaGOs92
reviewed
Jan 26, 2024
|
Test :
Il faudrait virer le premier if (client.id) dans alert-published-bal ligne 30
|
|
Tests :
|
|
Les méthodes "onSubmit" et "checkOtherBALs" des composants upload-form et create-form sont quasiment identiques. C'était pas possible de les déclarer dans la page new et de les passer en props pour éviter de dupliquer le code? |
Il y a une PR sur mes-adresses-api pour ca https://github.com/BaseAdresseNationale/mes-adresses-api/pull/423/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTEXT
Il y a des confusions lors de la création des BALs, certains ne savent pas que c'est déjà géré pour eux ou qu'ils ont déjà une BAL.
FONCTIONNALITE
Ajout d'une popup d'avertissement a la création d'une BAL si une révision existe deja
RESULTAT
Si une BAL a déjà été publié via mes-adresses
Si une BAL a déjà été publié via le moissonneur
Si une BAL a déjà été publié via l'api-depot
PR