migration: api-depot postgres #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
MaGOs92
reviewed
Nov 26, 2024
| @@ -0,0 +1,174 @@ | |||
| // HABILITATION | |||
|
|
|||
| export enum StatusHabilitationEnum { | |||
There was a problem hiding this comment.
On pourrait pas exporter ces types via OpenAPI, comme pour le signalement et mes-adresses? Je vois qu'ils sont dupliqués dans pas mal d'endroits.
ça sera plus simple à maintenir
There was a problem hiding this comment.
J'aimerais bien mais dans un second temps
On peut le faire pour l'api-depot et le moissonneur dans quasiment toutes nos briques.
Je voulais que la migration soit la plus petite possible dans un premier temps
src/lib/types/api-depot.types.ts
Outdated
| }; | ||
|
|
||
| export type Revision = { | ||
| id?: string; |
There was a problem hiding this comment.
Pourquoi les Ids sont optionnelles? (Aussi pour les files, mandataires, chef de file)
There was a problem hiding this comment.
Pour aucune raison --' c'est corrigé
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR