Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provides a solution for #82 #83

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Provides a solution for #82 #83

merged 1 commit into from
Feb 28, 2018

Conversation

ElteHupkes
Copy link
Contributor

@ElteHupkes ElteHupkes commented Feb 28, 2018 •
edited
Loading

This PR makes the following changes to accomodate #82 :

  • The SlideoutPanDelegate is updated to only respond to initial touches within the active area
  • The _ignorePan functionality is no longer needed and removed
  • SidebarController._sidebar is exposed in a public Sidebar property so more elaborate changes can be made to its gestures if necessary.

@ElteHupkes ElteHupkes mentioned this pull request Feb 28, 2018
Open
@jdehlin jdehlin merged commit 683451c into Baseflow:master Feb 28, 2018
@jdehlin
Copy link
Contributor

jdehlin commented Feb 28, 2018

Thanks for the PR!

@ElteHupkes
Copy link
Contributor Author

You're welcome, thanks for all the rest of the code :D.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijn00 martijn00 martijn00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElteHupkes @jdehlin @martijn00