feat: add parameter selectedCell?: TwoWayBindable<RowColumn> for listview widget
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Basssiiie Please have a look whenever it's convenient for you :) |
|
Hey thank you for your contribution! I've had a test and while the callback binding seems to work well, updating the currently selected row by setting the store does not seem to work. It looks like the problem is a bit more complex than I first assumed, as it seems we're dealing with an object on the property side and a dual parameter output on the callback side. 😅 I'll try to have a look myself what would be necessary to fully support the two way binding here and I'll get back to you when I know. |
|
The new property is merged with the additional changes that were needed. Thanks again for your contribution! 😄 I'll get a new release out soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #36: Add parameter
selectedCell?: TwoWayBindable<RowColumn>forlistviewwidget. Tested locally without issue.This is my first time contributing to this project, so please review my code carefully for any mistakes/areas for improvement. Thanks!