Fix turborepo and use react/jsx-curly-brace-presence

Becklyn-Studios · Jan 29, 2025 · 380d95c · 380d95c
1 parent 3933266
commit 380d95c
Show file tree

Hide file tree

Showing 9 changed files with 102 additions and 100 deletions.
diff --git a/.changeset/flat-pillows-kneel.md b/.changeset/flat-pillows-kneel.md
@@ -0,0 +1,5 @@
+---
+"@becklyn/eslint": patch
+---
+
+Fix turborepo integration
diff --git a/.changeset/young-apes-whisper.md b/.changeset/young-apes-whisper.md
@@ -0,0 +1,5 @@
+---
+"@becklyn/eslint": patch
+---
+
+Use react/jsx-curly-brace-presence
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/eslint/README.md b/packages/eslint/README.md
@@ -37,3 +37,25 @@ import { config } from "@becklyn/eslint/base";
 /** @type {import("eslint").Linter.Config} */
 export default config;
 ```
+
+
+## Turborepo
+
+When using turborepo you might want to check for undeclared env variables.
+
+Install `eslint-plugin-turbo`: `npm install -D eslint-plugin-turbo`
+
+```js
+import { config } from "@becklyn/eslint/base";
+import turboPlugin from "eslint-plugin-turbo";
+
+/** @type {import("eslint").Linter.Config} */
+export default [...nextJsConfig, {
+  plugins: {
+    turbo: turboPlugin,
+  },
+  rules: {
+      "turbo/no-undeclared-env-vars": "warn",
+  },
+}];
+```
diff --git a/packages/eslint/base.js b/packages/eslint/base.js
@@ -1,6 +1,5 @@
 import js from "@eslint/js";
 import eslintConfigPrettier from "eslint-config-prettier";
-import turboPlugin from "eslint-plugin-turbo";
 import tseslint from "typescript-eslint";
 import importAlias from "@limegrass/eslint-plugin-import-alias";
 
@@ -26,14 +25,6 @@ export const config = [
             ],
         },
     },
-    {
-        plugins: {
-            turbo: turboPlugin,
-        },
-        rules: {
-            "turbo/no-undeclared-env-vars": "warn",
-        },
-    },
     {
         ignores: ["dist/**"],
     },

diff --git a/packages/eslint/eslint.js b/packages/eslint/eslint.js
diff --git a/packages/eslint/next.js b/packages/eslint/next.js
@@ -13,37 +13,41 @@ import { config as baseConfig } from "./base.js";
  * @type {import("eslint").Linter.Config}
  * */
 export const nextJsConfig = [
-  ...baseConfig,
-  js.configs.recommended,
-  eslintConfigPrettier,
-  ...tseslint.configs.recommended,
-  {
-    ...pluginReact.configs.flat.recommended,
-    languageOptions: {
-      ...pluginReact.configs.flat.recommended.languageOptions,
-      globals: {
-        ...globals.serviceworker,
-      },
+    ...baseConfig,
+    js.configs.recommended,
+    eslintConfigPrettier,
+    ...tseslint.configs.recommended,
+    {
+        ...pluginReact.configs.flat.recommended,
+        languageOptions: {
+            ...pluginReact.configs.flat.recommended.languageOptions,
+            globals: {
+                ...globals.serviceworker,
+            },
+        },
     },
-  },
-  {
-    plugins: {
-      "@next/next": pluginNext,
+    {
+        plugins: {
+            "@next/next": pluginNext,
+        },
+        rules: {
+            ...pluginNext.configs.recommended.rules,
+            ...pluginNext.configs["core-web-vitals"].rules,
+        },
     },
-    rules: {
-      ...pluginNext.configs.recommended.rules,
-      ...pluginNext.configs["core-web-vitals"].rules,
+    {
+        plugins: {
+            "react-hooks": pluginReactHooks,
+        },
+        settings: { react: { version: "detect" } },
+        rules: {
+            ...pluginReactHooks.configs.recommended.rules,
+            // React scope no longer necessary with new JSX transform.
+            "react/react-in-jsx-scope": "off",
+            "react/jsx-curly-brace-presence": [
+                "error",
+                { props: "never", children: "never", propElementValues: "ignore" },
+            ],
+        },
     },
-  },
-  {
-    plugins: {
-      "react-hooks": pluginReactHooks,
-    },
-    settings: { react: { version: "detect" } },
-    rules: {
-      ...pluginReactHooks.configs.recommended.rules,
-      // React scope no longer necessary with new JSX transform.
-      "react/react-in-jsx-scope": "off",
-    },
-  },
 ];
diff --git a/packages/eslint/package.json b/packages/eslint/package.json
@@ -27,7 +27,6 @@
         "eslint-plugin-only-warn": "^1.1.0",
         "eslint-plugin-react": "^7.37.4",
         "eslint-plugin-react-hooks": "^5.1.0",
-        "eslint-plugin-turbo": "^2.3.4",
         "globals": "^15.14.0",
         "typescript": "^5.7.3",
         "typescript-eslint": "^8.22.0"

diff --git a/packages/eslint/react-internal.js b/packages/eslint/react-internal.js
@@ -11,29 +11,33 @@ import { config as baseConfig } from "./base.js";
  *
  * @type {import("eslint").Linter.Config} */
 export const config = [
-  ...baseConfig,
-  js.configs.recommended,
-  eslintConfigPrettier,
-  ...tseslint.configs.recommended,
-  pluginReact.configs.flat.recommended,
-  {
-    languageOptions: {
-      ...pluginReact.configs.flat.recommended.languageOptions,
-      globals: {
-        ...globals.serviceworker,
-        ...globals.browser,
-      },
+    ...baseConfig,
+    js.configs.recommended,
+    eslintConfigPrettier,
+    ...tseslint.configs.recommended,
+    pluginReact.configs.flat.recommended,
+    {
+        languageOptions: {
+            ...pluginReact.configs.flat.recommended.languageOptions,
+            globals: {
+                ...globals.serviceworker,
+                ...globals.browser,
+            },
+        },
     },
-  },
-  {
-    plugins: {
-      "react-hooks": pluginReactHooks,
+    {
+        plugins: {
+            "react-hooks": pluginReactHooks,
+        },
+        settings: { react: { version: "detect" } },
+        rules: {
+            ...pluginReactHooks.configs.recommended.rules,
+            // React scope no longer necessary with new JSX transform.
+            "react/react-in-jsx-scope": "off",
+            "react/jsx-curly-brace-presence": [
+                "error",
+                { props: "never", children: "never", propElementValues: "ignore" },
+            ],
+        },
     },
-    settings: { react: { version: "detect" } },
-    rules: {
-      ...pluginReactHooks.configs.recommended.rules,
-      // React scope no longer necessary with new JSX transform.
-      "react/react-in-jsx-scope": "off",
-    },
-  },
 ];