Skip to content

Commit

Permalink
Fix grpc runtime stop
Browse files Browse the repository at this point in the history
  • Loading branch information
jesko-plitt committed Feb 16, 2024
1 parent 28ee5eb commit 1c9e7f4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# vNext

# v1.4.2

- (bug) Fix grpc runtime stop

# v1.4.1

- (bug) Fix grpc runtime stop
Expand Down
2 changes: 1 addition & 1 deletion grpc/grpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func New(lifecycle *app.Lifecycle, logger golog.Logger) *grpc.Server {
return nil
})

lifecycle.OnStop(func(ctx context.Context) error {
lifecycle.OnStopLast(func(ctx context.Context) error {
stopped := make(chan bool)
go func() {
server.GracefulStop()
Expand Down

0 comments on commit 1c9e7f4

Please sign in to comment.