fix: exit with success boolean

[alexmaras]

This makes the exit code 1 when an error occurred in the underlying DBT invocation, and zero otherwise. It's particularly necessary for CI, where the current code will not surface errors

Summary by Sourcery

Fix the exit code behavior to return a non-zero code on DBT invocation errors, improving error detection in CI environments.

Bug Fixes:

• Ensure the program exits with a non-zero code when an error occurs during the DBT invocation, allowing CI to correctly detect failures.

[Bilbottom]

Thanks for catching this and raising the PR!

I'm just trying to understand the change -- have you confirmed that adding the return would push the correct exit code?

Looking at the dbt docs for the programmatic invocation, I was expecting something like:

Suggested change

	return not result.success
	if result.success:
	sys.exit(0)
	elif result.exception is None:
	sys.exit(1)
	else:
	sys.exit(2)

Given that people are actually using this repo, I'll also get the integration tests fixed this afternoon

[alexmaras]

Thanks - I was mainly looking for the failure case in general. The setup you've got is more correct, my fix was just a quick one I did for a CI pipeline. Glad to see there's proper guidance on how to deal with it. For reference, return does indeed produce correct statuses, though sys.exit is likely more correct.

[Bilbottom]

@alexmaras I've raised #37 with this change, as I've also added some integration tests and updated the project version (I don't have automated releases yet)

• Respect the dbt exit codes #37

Let me know if you're happy with this alternative, and I'll get it released (I'll merge it in if I don't hear anything, probs tomorrow)

Thanks for the contribution 🎉

[alexmaras]

Thanks @Bilbottom - that looks great. I was just getting a quick fix in place for CI pipelines, your solutions is much more solid. I was going to ask about test processes and stuff, but it looks like you've covered that off in there. Thanks for that! I'll close this one.