Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right avatar link to people #141

Merged
merged 3 commits into from
Dec 19, 2019
Merged

Add right avatar link to people #141

merged 3 commits into from
Dec 19, 2019

Conversation

SaniHarouna-Mayer
Copy link
Contributor

added the right avatar link to people.yml
still missing: ebozin, jgong, mterban, nfuller, rgu, rkoch, sbandi, syxue, xhyang, xyun, yrakita, ytao, zguguchia.

Sani Harouna-Mayer and others added 2 commits December 18, 2019 23:04
… Still needed to be updated: bfrandsen, cyshi, ebozin, eculbertson, jcalamari, jgong, mterban, mwaddell, nfuller, rgu, rkoch, sbandi, syxue, xhyang, xyun, yrakita, ytao, zguguchia.
…g, mterban, nfuller, rgu, rkoch, sbandi, syxue, xhyang, xyun, yrakita, ytao, zguguchia.
@sbillinge
Copy link
Contributor

closes #140

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start. PLease see my comments. Also, it is failing tests....

db/people.yml Outdated
@@ -364,8 +364,7 @@ ebozin:
- Emil Bozin
- ES Bozin
- E. S. Bozin
avatar: https://avatars0.githubusercontent.com/u/37090959?s=400&u=a94748131d06d93dfcaa6144e497870755cd2fea&v=4
bio: bio
avatar: https://github.com/<username>.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did bio get lost? Also, should point to the blank avatar.

db/people.yml Outdated
@@ -596,7 +595,7 @@ jgong:
active: false
aka:
- James Gong
avatar: https://www.gravatar.com/avatar/00000000000000000000000000000000?d=mp&f=y
avatar: https://github.com/<username>.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls change back to the gravatar (blank)

@sbillinge sbillinge merged commit 3ada4c0 into Billingegroup:master Dec 19, 2019
@sbillinge
Copy link
Contributor

Thanks so much @SaniHarouna-Mayer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants