Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use field list for user inputs during cookiecut, overall improve language for getting started and cookiecutter guide #214

Merged
merged 11 commits into from
Dec 29, 2024

Conversation

bobleesj
Copy link
Collaborator

@bobleesj bobleesj commented Dec 29, 2024

I added some handy features that improve our cookiecutter doc:

1. Adopt visual elements using admonish feature in Sphinx

Here is a gentle warning:

Screenshot 2024-12-28 at 9 56 28 PM

2. Use "field list" feature https://sphinx-rtd-theme.readthedocs.io/en/stable/demo/lists_tables.html#field-list

Screenshot 2024-12-28 at 9 56 50 PM

-> it is easier to manage than using a table in .rst

3. Provide a higher-level overview of the cookiecutting process for new users:

Screenshot 2024-12-28 at 9 58 45 PM

@bobleesj
Copy link
Collaborator Author

bobleesj commented Dec 29, 2024

@sbillinge ready for review -

I believe I need 3-4 more PR iterations before I feel comfortable saying it's ready for full review (using rendered doc to review all together). Just pushing PRs along the way so that each PR doesn't become too bloated.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (docs@1e0d520). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             docs     #214   +/-   ##
=======================================
  Coverage        ?   50.00%           
=======================================
  Files           ?        2           
  Lines           ?       18           
  Branches        ?        0           
=======================================
  Hits            ?        9           
  Misses          ?        9           
  Partials        ?        0           

@@ -1,8 +1,8 @@
:tocdepth: -1

.. index:: frequently_asked_questions
.. index:: frequently-asked-questions
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that we may want to adopt

https://my-page/use-minus-sign-for-pages instead of https://my-page/user_undersocre_sign

ex) https://docs.github.com/en/pages/getting-started-with-github-pages/creating-a-github-pages-site

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I agree. I was moving in this direction with the bg-mpl-stylesheets and so on. Getting rid of underscores in URLs and filenames, and CLI args (but replacing them obviously in python code) as a standard.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that we may want to adopt

https://my-page/use-minus-sign-for-pages instead of https://my-page/user_undersocre_sign

ex) https://docs.github.com/en/pages/getting-started-with-github-pages/creating-a-github-pages-site

@sbillinge yup noted, I will just note this in the gitlab doc

@bobleesj
Copy link
Collaborator Author

@sbillinge ready for review -

I believe I need 3-4 more PR iterations before I feel comfortable saying it's ready for full review (using rendered doc to review all together). Just pushing PRs along the way so that each PR doesn't become too bloated.

Also, I am trying to apply our new commit standard, not perfect yet, but it's cementing:

Screenshot 2024-12-28 at 10 08 24 PM

@bobleesj
Copy link
Collaborator Author

@sbillinge would it be a good idea to merge to a temp branch like docs and once we are ready, we merge to main?

@sbillinge sbillinge changed the base branch from main to docs December 29, 2024 14:46
@sbillinge
Copy link
Collaborator

I added some handy features that improve our cookiecutter doc:

1. Adopt visual elements using admonish feature in Sphinx

Here is a gentle warning:
Screenshot 2024-12-28 at 9 56 28 PM

2. Use "field list" feature https://sphinx-rtd-theme.readthedocs.io/en/stable/demo/lists_tables.html#field-list

Screenshot 2024-12-28 at 9 56 50 PM

-> it is easier to manage than using a table in .rst

3. Provide a higher-level overview of the cookiecutting process for new users:

Screenshot 2024-12-28 at 9 58 45 PM

all really nice! I love it!

@sbillinge
Copy link
Collaborator

@sbillinge would it be a good idea to merge to a temp branch like docs and once we are ready, we merge to main?

ok done.

@sbillinge sbillinge merged commit 48c6fe0 into Billingegroup:docs Dec 29, 2024
5 checks passed
@bobleesj bobleesj deleted the admin-doc branch December 29, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants