-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use field list for user inputs during cookiecut, overall improve language for getting started and cookiecutter guide #214
Conversation
…into admin-doc
@sbillinge ready for review - I believe I need 3-4 more PR iterations before I feel comfortable saying it's ready for full review (using rendered doc to review all together). Just pushing PRs along the way so that each PR doesn't become too bloated. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## docs #214 +/- ##
=======================================
Coverage ? 50.00%
=======================================
Files ? 2
Lines ? 18
Branches ? 0
=======================================
Hits ? 9
Misses ? 9
Partials ? 0 |
@@ -1,8 +1,8 @@ | |||
:tocdepth: -1 | |||
|
|||
.. index:: frequently_asked_questions | |||
.. index:: frequently-asked-questions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that we may want to adopt
https://my-page/use-minus-sign-for-pages
instead of https://my-page/user_undersocre_sign
ex) https://docs.github.com/en/pages/getting-started-with-github-pages/creating-a-github-pages-site
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I agree. I was moving in this direction with the bg-mpl-stylesheets and so on. Getting rid of underscores in URLs and filenames, and CLI args (but replacing them obviously in python code) as a standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that we may want to adopt
https://my-page/use-minus-sign-for-pages
instead ofhttps://my-page/user_undersocre_sign
ex)
https://docs.github.com/en/pages/getting-started-with-github-pages/creating-a-github-pages-site
@sbillinge yup noted, I will just note this in the gitlab doc
@sbillinge ready for review - I believe I need 3-4 more PR iterations before I feel comfortable saying it's ready for full review (using rendered doc to review all together). Just pushing PRs along the way so that each PR doesn't become too bloated. Also, I am trying to apply our new commit standard, not perfect yet, but it's cementing: ![]() |
@sbillinge would it be a good idea to merge to a temp branch like |
all really nice! I love it! |
ok done. |
I added some handy features that improve our cookiecutter doc:
1. Adopt visual elements using
admonish
feature in SphinxHere is a gentle warning:
2. Use "field list" feature https://sphinx-rtd-theme.readthedocs.io/en/stable/demo/lists_tables.html#field-list
-> it is easier to manage than using a table in .rst
3. Provide a higher-level overview of the cookiecutting process for new users: