-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: update billinge email #247
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage 52.63% 52.63%
=======================================
Files 2 2
Lines 19 19
=======================================
Hits 10 10
Misses 9 9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be templated. Let's loop in Bob
yes lgtm. the modification is in |
Ah, I see, these are the user prompts. I think we should maybe remove my name from these altogether perhaps, and use more generic exemplar names? |
On the other hand, if we are the main users of this, having defaults that work for us would be good. How about an infrastructure where we can have a config.json file where you can define local defaults? |
I think having specific examples can indeed help reduce cognitive overload and for the email, it provides a sense of who is currently maintaining and developing this software as a contact point.
We could try to see if this approach works and whether we can import information into |
@sbillinge created issue #248. This can be addressed while also addressing #237 (package update) If we are okay with the default values of sbillinge info, this PR could be merged. |
@bobleesj in light of your comments, maybe we can leave my name there in general. I agree that a specific example is better than a generic one. But I also like the idea of a local config option. I could imagnie the "Bob Lee Group" in the future and you would much rather Bob Lee is the default than Simon Billinge for you and all your students....... |
Yes agreed! |
No description provided.