Tieqiong PR #3
Tieqiong PR #3
Conversation
There was a problem hiding this comment.
This PR has way too much on it to be able to review and merge I am afraid so we will have to close it. Also, it seems that it was not opened on a fork of the repo. It is a shame as there seems to be quite a bit of work on here, but maybe some of it can be reused.
@Tieqiong, it looks as if we need to go over the forking workflow and work up your group code workflow skills. Please take inspiration by looking at @Sparks29032 where he is doing very granular PRs with commits that capture different parts of the work and linking to issues. Please maybe work with Yuong in the office to try and learn how we like to do things.
|
Simon closing this, Please see the review Tieqiong |
|
@sbillinge This was a PR copied from the other repo, just for reference. Thanks for the comments |
|
Yes, thanks Tieqiong, Andrew let me know. All good! Nice to see the
activity!
…On Wed, Jun 19, 2024, 10:25 AM Tieqiong ***@***.***> wrote:
@sbillinge <https://github.com/sbillinge> This was a PR copied from the
other repo, just for reference. Thanks for the comments
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUIBUYYLKEB6FDN2XCTZIGIDPAVCNFSM6AAAAABJQ4NLR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZYHA2DSMZUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No description provided.