Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download RPC #1568

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix download RPC #1568

merged 1 commit into from
Jan 24, 2024

Conversation

rkervella
Copy link
Member

Return an error if the file doesn't exist.

@rkervella rkervella requested a review from a team as a code owner January 24, 2024 18:26
Copy link
Collaborator

@RafBishopFox RafBishopFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need a specific error returned for the condition where a file does not exist, then no problems. If the operator requests a filter, like C:\*.txt, and no files exist, this error will not be triggered. If we need that, then we will have to introduce that logic.

@RafBishopFox RafBishopFox self-requested a review January 24, 2024 19:37
Copy link
Collaborator

@RafBishopFox RafBishopFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon further review, this breaks filtering because the a request like C:\*.txt will throw that error.

Copy link
Collaborator

@RafBishopFox RafBishopFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to have logic to detect if a filter that is not a specific filename is involved, and if so, then let os.IsNotExist pass.

@RafBishopFox RafBishopFox self-requested a review January 24, 2024 19:56
Copy link
Collaborator

@RafBishopFox RafBishopFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. Operator error. Filtering seems fine.

@rkervella rkervella merged commit d0dc42e into master Jan 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants