Addressed review comments

Signed-off-by: Yi-Pin Chen <[email protected]>
Bit-Quill · Sep 4, 2024 · 1ad9408 · 1ad9408
1 parent 45fce14
commit 1ad9408
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/node/src/BaseClient.ts b/node/src/BaseClient.ts
@@ -951,19 +951,21 @@ export class BaseClient {
         let msg: PubSubMsg | null = null;
         const responsePointer = pushNotification.respPointer;
         let nextPushNotificationValue: Record<string, unknown> = {};
+        const isStringDecoder =
+            (decoder ?? this.defaultDecoder) === Decoder.String;
 
         if (responsePointer) {
             if (typeof responsePointer !== "number") {
                 nextPushNotificationValue = valueFromSplitPointer(
                     responsePointer.high,
                     responsePointer.low,
-                    (decoder ?? this.defaultDecoder) === Decoder.String,
+                    isStringDecoder,
                 ) as Record<string, unknown>;
             } else {
                 nextPushNotificationValue = valueFromSplitPointer(
                     0,
                     responsePointer,
-                    (decoder ?? this.defaultDecoder) === Decoder.String,
+                    isStringDecoder,
                 ) as Record<string, unknown>;
             }
 

diff --git a/node/tests/PubSub.test.ts b/node/tests/PubSub.test.ts
@@ -374,7 +374,7 @@ describe("PubSub", () => {
 
                 expect(pubsubMessage!.message).toEqual(message);
                 expect(pubsubMessage!.channel).toEqual(channel);
-                expect(pubsubMessage!.pattern).toEqual(null);
+                expect(pubsubMessage!.pattern).toBeNull();
 
                 await checkNoMessagesLeft(method, listeningClient, context, 1);
             } finally {
@@ -389,7 +389,7 @@ describe("PubSub", () => {
     );
 
     /**
-     * Tests the basic happy path for exact PUBSUB functionality with binary decoder.
+     * Tests the basic happy path for exact PUBSUB functionality with binary.
      *
      * This test covers the basic PUBSUB flow using three different methods:
      * Async, Sync, and Callback. It verifies that a message published to a
@@ -460,7 +460,7 @@ describe("PubSub", () => {
 
                 expect(pubsubMessage!.message).toEqual(Buffer.from(message));
                 expect(pubsubMessage!.channel).toEqual(Buffer.from(channel));
-                expect(pubsubMessage!.pattern).toEqual(null);
+                expect(pubsubMessage!.pattern).toBeNull();
 
                 await checkNoMessagesLeft(method, listeningClient, context, 1);
             } finally {