Add binary variant to PUBSUB subscribe commands #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Node: add binary support for PubSub commands, part 1 --------- Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
acarbonetto
approved these changes
Sep 4, 2024
| method, | ||
| listeningClient, | ||
| context, | ||
| index, | ||
| ); | ||
| ))!; |
There was a problem hiding this comment.
VS Code complaints that pubsubMsg is possibly null. So I have to add this.
Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
Yury-Fridlyand
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
I don't review tests, I trust you. If they past - all LGTM
yipin-chen
merged commit 04e9334
into
node/integ-valkey-293-return-record-with-glidestring
4 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add binary variant for the following commands:
PSubbscribeSubscribeSSubscribeUnsubscribeSUnsubscribePUnsubscribeAdd decoder option to PUBSUB's
createClient().Note: to complete
PUBSUBsubscribe commands, I have to cherry-pick already merged main branch PR valkey-io#2201.