Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootloader: add Hardware() endpoint #116

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

benma
Copy link
Contributor

@benma benma commented Jan 21, 2025

No description provided.

Copy link
Collaborator

@Beerosagos Beerosagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK with a tiny nit :)

fmt.Println("Product:", device.Product())
hardware, err := device.Hardware()
errpanic(err)
fmt.Println("Hardware:", hardware)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
fmt.Println("Hardware:", hardware)
fmt.Printf("Hardware: %+v\n", hardware)

to change the output from Hardware: &{ATECC} to Hardware: &{SecureChipModel:ATECC}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@benma benma merged commit 0e6a62c into BitBoxSwiss:master Jan 30, 2025
3 checks passed
@benma benma deleted the op_hardware branch January 30, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants