Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message shown if email not exits #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mihir-solanki-13
Copy link
Contributor

[Feature] Error Handling for Password Reset Email

This pull request adds error-handling functionality to the password reset feature. Previously, if a user entered an incorrect email or if the email did not exist, they were redirected to the next page without any notification.

With this change, if the user enters the wrong email or the email does not exist in the system, an error message is displayed, and the user is prevented from proceeding to the next page.

Changes made:

  • Added validation to check for email existence before proceeding with the password reset.
  • Display an error message if the email is not found or is incorrect.
  • Prevent redirection to the next page in case of an error.
  • Implemented asynchronous JavaScript code to handle form/button submission.

This enhancement improves the user experience by providing clear feedback and preventing unnecessary redirects in case of incorrect email inputs.

@garg3133
Copy link
Member

@Mihir-solanki-13 IMO we don't need a separate endpoint just to check if an email exists or not (from both design and security perspectives as it would allow anyone to hit that endpoint with an email address to check if that email is registered on the site or not). And, what you're assuming as a missing functionality is actually a security feature in Django framework because otherwise, anyone could go on the password reset page to check if an email address is registered on the site or not.

And it's true for every website, you would never find a serious application that reveals this information about its users. Instead, they all just say that if the email address is registered on the application, you will get a password reset link soon, otherwise you won't.

So, I would suggest not to add this enhancement to the Alumni site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants