Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex spending conditions how it works page #1037

Conversation

rabbitholiness
Copy link
Collaborator

@rabbitholiness rabbitholiness commented Sep 21, 2023

This PR is related to issue #992 about creating a "How it works" page for complex spending conditions (Miniscript).

Preview shortcut link: https://deploy-preview-1037--bitcoin-design-site.netlify.app/guide/how-it-works/custom-spending-conditions/

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit fbd801b
🔍 Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/651ea4fcf6ff500008534d87
😎 Deploy Preview https://deploy-preview-1037--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- Some small text revisions
- Alt-texts and captions for images
- Added links to relevant pages in the guide as well as external resources
@rabbitholiness rabbitholiness marked this pull request as ready for review September 22, 2023 09:36
rabbitholiness and others added 6 commits September 22, 2023 13:12
Updated the next button label and target link to lead to the Complex Spending Conditions page.
Added link and description for the custom spending conditions page.
Improved distinction between relative and absolute timelocks.
Copy link
Collaborator

@mouxdesign mouxdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor copy suggestions for readability. But looks great, thank you for putting this together.

guide/how-it-works/custom-spending-conditions.md Outdated Show resolved Hide resolved
guide/how-it-works/custom-spending-conditions.md Outdated Show resolved Hide resolved
guide/how-it-works/custom-spending-conditions.md Outdated Show resolved Hide resolved
guide/how-it-works/custom-spending-conditions.md Outdated Show resolved Hide resolved
guide/how-it-works/custom-spending-conditions.md Outdated Show resolved Hide resolved
Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just had some minor recommendations.

Would also be good to get that Gemfile.lock file out of the PR.

guide/how-it-works/custom-spending-conditions.md Outdated Show resolved Hide resolved
guide/how-it-works/custom-spending-conditions.md Outdated Show resolved Hide resolved
guide/how-it-works/custom-spending-conditions.md Outdated Show resolved Hide resolved
guide/how-it-works/custom-spending-conditions.md Outdated Show resolved Hide resolved
guide/how-it-works/custom-spending-conditions.md Outdated Show resolved Hide resolved
guide/how-it-works/custom-spending-conditions.md Outdated Show resolved Hide resolved
guide/how-it-works/wallet-selector.md Show resolved Hide resolved
guide/how-it-works/introduction.md Outdated Show resolved Hide resolved
Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. The page is great. Let's merge it.

@GBKS GBKS requested a review from danielnordh October 6, 2023 06:24
Copy link
Contributor

@danielnordh danielnordh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants