-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complex spending conditions how it works page #1037
Complex spending conditions how it works page #1037
Conversation
Created a new page and set up the structure of the copy.
Removed superfluous subtitle and changed page name
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Some small text revisions - Alt-texts and captions for images - Added links to relevant pages in the guide as well as external resources
Co-authored-by: Christoph Ono <[email protected]>
Updated the next button label and target link to lead to the Complex Spending Conditions page.
Added link and description for the custom spending conditions page.
Improved distinction between relative and absolute timelocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor copy suggestions for readability. But looks great, thank you for putting this together.
Co-authored-by: Mogashni <[email protected]>
Co-authored-by: Mogashni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just had some minor recommendations.
Would also be good to get that Gemfile.lock file out of the PR.
Co-authored-by: Christoph Ono <[email protected]>
Co-authored-by: Christoph Ono <[email protected]>
Co-authored-by: Christoph Ono <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. The page is great. Let's merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is related to issue #992 about creating a "How it works" page for complex spending conditions (Miniscript).
Preview shortcut link: https://deploy-preview-1037--bitcoin-design-site.netlify.app/guide/how-it-works/custom-spending-conditions/