Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

famistudio_music_pause no longer stops sampled sound effects #367

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Teuthida255
Copy link

Originally, this subroutine's blanket call to famistudio_sample_stop would cause the channel to stop playing even if it was playing a sound effect instead of music; this request adds a brief check to famistudio_dpcm_effect before calling the function to skip it if a sound effect is playing in the channel.

@BleuBleu
Copy link
Owner

For this to be considered, you would need to :

  1. Do all 4 assemblers
  2. Run unit test to ensure binary identical engines

-Mat

@BleuBleu
Copy link
Owner

BleuBleu commented Jan 3, 2025

Im preparing 4.3.1 soon, please address the 2 issues i raised otherwise it will not make it into the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants