Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1500 add physical cd drive support #1609

Merged
merged 31 commits into from
Jan 23, 2025
Merged

1500 add physical cd drive support #1609

merged 31 commits into from
Jan 23, 2025

Conversation

midwan
Copy link
Collaborator

@midwan midwan commented Jan 23, 2025

Not fully working yet, but might as well merge what has been done and proceed with fixes on the master branch from there.

The Add CD button in the GUI will remain disabled until this works as expected

midwan added 30 commits November 13, 2024 21:44
@midwan
feat: Add physical CD drive support in the GUI
f33887f
@midwan
refactor: fix cdrom device names
1feb58c
@midwan
refactor: remove unnecessary type change
72507c2
@midwan
refactor: store rootdir for CD devices in Amiberry
1aa52e6 
Since we're not on Windows, we need the path to the device, not a one-letter drive.
@midwan
feat: auto-detect and list physical cd drives in dropdowns
d6fab36
@midwan
refactor: added cdfs automount cd drives option in GUI
a438cc3
@midwan
refactor: remove cd lists from dropdowns
e17794c
@midwan
refactor: minor optimizations in amiberry_filesys
d365ada
@midwan
fixed build
317d312
@midwan
feat: added blkdev_ioctl
9ff49ba 
First version of file, there may still be bugs there.
This adds support for controlling physical CD/DVD devices using IOCTL
@midwan
Squashed commit of the following:
9a41642 
commit d9804b3
Author: Dimitris Panokostas <[email protected]>
Date:   Sat Nov 16 10:48:46 2024 +0100

    Update README.md (#1511)
@midwan
Disable this for macOS for now
56dc56a 
There are too many differences to go into this for macOS at the moment.
Disabling this piece for now, will come back to it in the future
@midwan
better separation for macOS
9be4a72
@midwan
Add device options in dropdowns.
79ee7e5 
Fix windows-specific drive letter detection in blkdev
@midwan
refactor sys_cddev_open
e420a8a
@midwan
refactor: improve IOCTL device detection
22d02f0
@midwan
silence some log entries that are making too much noise
317c385
@midwan
refactor: fetch geometry
f286499
@midwan
refactor: remove no-op functions
24190ae
@midwan
refactor: close and re-open file handle when opening
24e4725
@midwan
Squashed commit of the following:
fe82bb1 
commit 75572f4
Author: Dimitris Panokostas <[email protected]>
Date:   Sat Nov 23 10:59:04 2024 +0100

    bugfix: ensure CPack also has correct capitalization (fixes #1514)

commit 2e70acc
Author: Dimitris Panokostas <[email protected]>
Date:   Sat Nov 23 10:45:29 2024 +0100

    bugfix: Linux builds should have PROJECT_NAME in lower case

    Looks like the CMAKE_SYSTEM_NAME variable is only valid AFTER the project is set.
    We need a capitalized name for macOS builds, but lowercase for linux ones.

commit a1591ee
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 20:55:07 2024 +0100

    chore: only write config options if they are enabled

    - Manual Crop
    - Drawbridge

    These options would be written to the config always, even if not enabled

commit 249a132
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 20:48:03 2024 +0100

    chore: bump options version to 7.0.0

commit 85044a8
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 18:57:06 2024 +0100

    enhancement: add ".vbi" in global ROM extensions also #1507

commit 63fee15
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 18:54:22 2024 +0100

    fix typo

    It's not vdi, but vbi

commit 2c1e921
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 18:52:07 2024 +0100

    bugfix: allow .vdi selection in Expansions ROMs #1507

    These types of files are VGA rom files, but they were filtered out based on the filename extensions

commit 1718e2c
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 18:38:44 2024 +0100

    bugfix: #1507 Expansions GUI CPU board fixes

    When selecting a CPU board from the dropdown, the sub-options did not get enables as expected

commit f7f09bf
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 08:39:49 2024 +0100

    Update README.md

    Remove obsolete info about bypassing security on MacOS installation

commit 9d0c218
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 00:46:20 2024 +0100

    ci: added missing team ID

commit a197c86
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 00:36:07 2024 +0100

    ci: added notary service steps

commit 10fe364
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 00:04:40 2024 +0100

    ci: fix macOS signing

commit 97a7021
Author: Dimitris Panokostas <[email protected]>
Date:   Thu Nov 21 23:53:19 2024 +0100

    ci: fix capitalization for MacOS App bundle

commit 0fe6e54
Author: Dimitris Panokostas <[email protected]>
Date:   Thu Nov 21 23:53:00 2024 +0100

    ci: Add Apple certificate signing to dylibs and app bundle

commit 0344272
Author: Dimitris Panokostas <[email protected]>
Date:   Thu Nov 21 20:29:38 2024 +0100

    ci: Added missing create keychain step

commit 935fcda
Author: Dimitris Panokostas <[email protected]>
Date:   Thu Nov 21 20:09:34 2024 +0100

    ci: add apple signing certificate setup in workflow

commit d9804b3
Author: Dimitris Panokostas <[email protected]>
Date:   Sat Nov 16 10:48:46 2024 +0100

    Update README.md (#1511)
@midwan
Merge branch 'master' into 1500-add-physical-cd-drive-support
261719b
@midwan
Merge branch 'master' into 1500-add-physical-cd-drive-support
618d72f
@midwan
refactor: revert vbi changes #1515
cc3d3a7
@midwan
Merge branch 'master' into 1500-add-physical-cd-drive-support
c2eeb04
@midwan
Merge branch 'master' into 1500-add-physical-cd-drive-support
1785c5e 
# Conflicts:
#	src/osdep/amiberry.cpp
#	src/osdep/gui/PanelHD.cpp
#	src/osdep/gui/PanelQuickstart.cpp
@midwan
Fixes after merge
1ce4f76
@midwan
refactor: use const in more places
8fd2ff4
@midwan
Merge branch 'master' into 1500-add-physical-cd-drive-support
6e988f2 
# Conflicts:
#	src/osdep/cda_play.cpp
#	src/osdep/cda_play.h
#	src/osdep/gui/PanelHD.cpp
@midwan
refactor: cdda_play should be int
c0db52f
@midwan midwan linked an issue Jan 23, 2025 that may be closed by this pull request
Add physical CD drive support #1500
Closed
@midwan midwan merged commit f7f19a9 into master Jan 23, 2025
24 checks passed
@midwan midwan deleted the 1500-add-physical-cd-drive-support branch January 23, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add physical CD drive support
1 participant
@midwan