Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Debian 12 #47

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Conversation

BuildWithData
Copy link
Contributor

@BuildWithData BuildWithData commented Oct 14, 2023

Goal: make both standup scripts work with Debian 12

Why this patch ?

  • bcs wget started writing logs file as explained more in details here
  • to update readme file and let users know they can run both scripts with debian 12

Other comments

  • The workaround described here works however the append option -a is preferred to option -o, this way we have a single log file for wget and then it is easier to append logs to standup.log and standup.err log files

  • wget command is used other 2 times in the scripts, but without sudo -u standup, ie no issues with logs here and no need to add option -a

  • changes are retrocompatible and work also on Debian 11 but StandUp.sh script has been tested only

TODO

  • test LinodeStandUp.sh
  • test StandUp.sh
  • test LinodeStandUp.sh by maintainer
  • test StandUp.sh by maintainer
  • do not forget to squash commits

NEXT STEPS

  • if pull is approved and merged then patch also here to let users know they can run on debian 12

@BuildWithData BuildWithData mentioned this pull request Oct 14, 2023
@shannona shannona requested review from shannona and removed request for ChristopherA October 17, 2023 22:02
Copy link
Contributor

@shannona shannona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success with both LinodeStandup and Standup shell scripts.

@shannona shannona merged commit dd84df1 into BlockchainCommons:master Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants