Update vendored version of secp256k1-zkp #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should really be folded into the next commit, since these patches do not apply to the currently-vendored version of libsecp-zkp. But to make review easier I am doing them in a separate commit. This updates the patchfiles to delete the context and scratch space allocation/deallocation functions. Upstream has updated the comments and other minor stuff so the old patchfiles did not work. While I am at it, change the patchfiles from normal diffs to git-diffs, since we have git available and it's easier to use git since it can figure out paths correctly.
Also bump versions of rust-secp-zkp-sys and rust-secp-zkp.
jonasnick
reviewed
Jul 9, 2024
|
Added a commit with CHANGELOG entries. |
jonasnick
approved these changes
Jul 9, 2024
|
Tagged, and published both crates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bump major version of both secp256k1-zkp and secp256k1-zkp-sys.
Next step toward ElementsProject/rust-elements#202 (comment)