Precise type splits #180
Closed
Precise type splits #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncomputable
force-pushed
the
types
branch
5 times, most recently
from
a60b5c8 to
503f09f
Compare
Regex crate requires rust 1.65+
We assert that the type is a sum / product and access its children at the same time. This is more precise than using split.
These methods are more precise and make the code more readable.
Simplifies the code
apoelstra
approved these changes
Nov 27, 2023
apoelstra
added a commit
that referenced
this pull request
Nov 27, 2023
e0a2cae Bit Machine: Split types (Christian Lewe) 8cc05da Types: Replace split with split_{sum, product} (Christian Lewe) 1afbd35 Types: Split sum and product (Christian Lewe) cbfa045 Fuzz: Update toolchain (Christian Lewe) dd2e7f8 MSRV: Pin byteorder (Christian Lewe) 454727e Clippy: Fix lints (Christian Lewe) Pull request description: Split sum and product types with separate methods for better readability. ACKs for top commit: apoelstra: ACK e0a2cae Tree-SHA512: e36c41714c9a9c102e4069448696d002fbc844d677bbdf5ccfb83c0dbbf84ff68950b474c8310f23d7018f6171ba8098f9f1f80559cc3f8b3d99027208d6dbc4
|
Merged. I dunno why github thinks it's closed. |
|
Awesome, thanks. The red icon looks scary, but the merge is what counts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split sum and product types with separate methods for better readability.