Encode QoL #183
Merged
Encode QoL #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncomputable
force-pushed
the
encode
branch
2 times, most recently
from
522d4a0 to
8bf07d6
Compare
uncomputable
added a commit
to uncomputable/asset-gen
that referenced
this pull request
Dec 5, 2023
We can start using rust-simplicity master once three PRs are merged: BlockstreamResearch/rust-simplicity#179 BlockstreamResearch/rust-simplicity#182 BlockstreamResearch/rust-simplicity#183
apoelstra
reviewed
Dec 5, 2023
|
8bf07d6 looks great! My comment is a minor thing (but I do want it changed before we merge). |
Every public method should return the number of written bits.
The new algorithm is nonrecursive.
We often write bits to a byte vector. write_to_vec generalizes this workflow by writing the result of any bit operation into a byte vector, which it returns. The caller doesn't have to worry about I/O errors that can never occur.
|
Rebased and turned |
apoelstra
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve quality of life in the encode module.