Fix lint issues

src/array.rs

@@ -20,7 +20,7 @@ impl<'a, A> BTreeSlice<'a, A> {
     }
 }
 
-impl<'a, A: Clone> BTreeSlice<'a, A> {
+impl<A: Clone> BTreeSlice<'_, A> {
     /// Fold the tree in post order, using the binary function `f`.
     ///
     /// Returns `None` if the tree is empty.
@@ -57,7 +57,7 @@ impl<'a, A: Clone> BTreeSlice<'a, A> {
     }
 }
 
-impl<'a, A: Clone> TreeLike for BTreeSlice<'a, A> {
+impl<A: Clone> TreeLike for BTreeSlice<'_, A> {
     fn as_node(&self) -> Tree<Self> {
         match self.0.len() {
             0 | 1 => Tree::Nullary,
@@ -169,7 +169,7 @@ impl<'a, A> Partition<'a, A> {
     }
 }
 
-impl<'a, A: Clone> Partition<'a, A> {
+impl<A: Clone> Partition<'_, A> {
     /// Check if the partition is complete.
     ///
     /// A complete partition contains no empty blocks.
@@ -213,7 +213,7 @@ impl<'a, A: Clone> Partition<'a, A> {
 }
 
 #[rustfmt::skip]
-impl<'a, A: Clone> TreeLike for Partition<'a, A> {
+impl<A: Clone> TreeLike for Partition<'_, A> {
     fn as_node(&self) -> Tree<Self> {
         match self {
             Self::Leaf {..} => Tree::Nullary,

src/ast.rs

@@ -426,7 +426,7 @@ pub enum ExprTree<'a> {
     Match(&'a Match),
 }
 
-impl<'a> TreeLike for ExprTree<'a> {
+impl TreeLike for ExprTree<'_> {
     fn as_node(&self) -> Tree<Self> {
         use SingleExpressionInner as S;
 

src/error.rs

@@ -144,7 +144,7 @@ impl<'a> From<&'a pest::iterators::Pair<'_, Rule>> for Span {
     }
 }
 
-impl<'a> From<&'a str> for Span {
+impl From<&str> for Span {
     fn from(s: &str) -> Self {
         let start = Position::new(1, 1);
         let end_line = std::cmp::max(1, s.lines().count());

src/lib.rs

@@ -1,4 +1,4 @@
-/// Library for parsing and compiling simfony
+//! Library for parsing and compiling simfony
 
 pub type ProgNode = Arc<named::ConstructNode>;
 
@@ -247,6 +247,7 @@ pub trait ArbitraryOfType: Sized {
 mod tests {
     use base64::display::Base64Display;
     use base64::engine::general_purpose::STANDARD;
+    #[cfg(feature = "serde")]
     use elements::LockTime;
     use simplicity::BitMachine;
     use std::borrow::Cow;

src/parse.rs

@@ -544,7 +544,7 @@ pub enum ExprTree<'a> {
     Match(&'a Match),
 }
 
-impl<'a> TreeLike for ExprTree<'a> {
+impl TreeLike for ExprTree<'_> {
     fn as_node(&self) -> Tree<Self> {
         use SingleExpressionInner as S;
 
@@ -596,7 +596,7 @@ impl<'a> TreeLike for ExprTree<'a> {
     }
 }
 
-impl<'a> fmt::Display for ExprTree<'a> {
+impl fmt::Display for ExprTree<'_> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         use SingleExpressionInner as S;
 
@@ -1512,7 +1512,7 @@ impl PestParse for ModuleAssignment {
 #[derive(Clone, Debug)]
 struct PatternPair<'a>(pest::iterators::Pair<'a, Rule>);
 
-impl<'a> TreeLike for PatternPair<'a> {
+impl TreeLike for PatternPair<'_> {
     fn as_node(&self) -> Tree<Self> {
         let mut it = self.0.clone().into_inner();
         match self.0.as_rule() {
@@ -1534,7 +1534,7 @@ impl<'a> TreeLike for PatternPair<'a> {
 #[derive(Clone, Debug)]
 struct TyPair<'a>(pest::iterators::Pair<'a, Rule>);
 
-impl<'a> TreeLike for TyPair<'a> {
+impl TreeLike for TyPair<'_> {
     fn as_node(&self) -> Tree<Self> {
         let mut it = self.0.clone().into_inner();
         match self.0.as_rule() {

src/pattern.rs

@@ -72,7 +72,7 @@ impl Pattern {
     }
 }
 
-impl<'a> TreeLike for &'a Pattern {
+impl TreeLike for &Pattern {
     fn as_node(&self) -> Tree<Self> {
         match self {
             Pattern::Identifier(_) | Pattern::Ignore => Tree::Nullary,
@@ -170,7 +170,7 @@ pub enum BasePattern {
     Product(Arc<Self>, Arc<Self>),
 }
 
-impl<'a> TreeLike for &'a BasePattern {
+impl TreeLike for &BasePattern {
     fn as_node(&self) -> Tree<Self> {
         match self {
             BasePattern::Ignore | BasePattern::Identifier(_) => Tree::Nullary,

src/types.rs

@@ -193,7 +193,7 @@ impl fmt::Display for UIntType {
     }
 }
 
-impl<'a> TryFrom<&'a StructuralType> for UIntType {
+impl TryFrom<&StructuralType> for UIntType {
     type Error = ();
 
     fn try_from(value: &StructuralType) -> Result<Self, Self::Error> {
@@ -215,7 +215,7 @@ impl<'a> TryFrom<&'a StructuralType> for UIntType {
     }
 }
 
-impl<'a> TryFrom<&'a ResolvedType> for UIntType {
+impl TryFrom<&ResolvedType> for UIntType {
     type Error = ();
 
     fn try_from(value: &ResolvedType) -> Result<Self, Self::Error> {
@@ -402,7 +402,7 @@ impl TypeDeconstructible for ResolvedType {
     }
 }
 
-impl<'a> TreeLike for &'a ResolvedType {
+impl TreeLike for &ResolvedType {
     fn as_node(&self) -> Tree<Self> {
         match &self.0 {
             TypeInner::Boolean | TypeInner::UInt(..) => Tree::Nullary,
@@ -698,7 +698,7 @@ impl TypeDeconstructible for AliasedType {
     }
 }
 
-impl<'a> TreeLike for &'a AliasedType {
+impl TreeLike for &AliasedType {
     fn as_node(&self) -> Tree<Self> {
         match &self.0 {
             AliasedInner::Alias(_) | AliasedInner::Builtin(_) => Tree::Nullary,
@@ -974,7 +974,7 @@ impl From<UIntType> for StructuralType {
     }
 }
 
-impl<'a> From<&'a ResolvedType> for StructuralType {
+impl From<&ResolvedType> for StructuralType {
     fn from(value: &ResolvedType) -> Self {
         let mut output = vec![];
         for data in value.post_order_iter() {

src/value.rs

@@ -395,7 +395,7 @@ pub struct Value {
     ty: ResolvedType,
 }
 
-impl<'a> TreeLike for &'a Value {
+impl TreeLike for &Value {
     fn as_node(&self) -> Tree<Self> {
         match &self.inner {
             ValueInner::Option(None) | ValueInner::Boolean(_) | ValueInner::UInt(_) => {
@@ -443,10 +443,11 @@ impl fmt::Display for Value {
                     }
                 },
                 ValueInner::Boolean(bit) => write!(f, "{bit}")?,
-                ValueInner::UInt(integer) => match print_hex_byte_array {
-                    false => write!(f, "{integer}")?,
-                    true => {} // bytes have already been printed
-                },
+                ValueInner::UInt(integer) => {
+                    if !print_hex_byte_array {
+                        write!(f, "{integer}")?
+                    }
+                }
                 ValueInner::Tuple(tuple) => {
                     if data.n_children_yielded == 0 {
                         write!(f, "(")?;
@@ -998,7 +999,7 @@ impl From<UIntValue> for StructuralValue {
     }
 }
 
-impl<'a> From<&'a Value> for StructuralValue {
+impl From<&Value> for StructuralValue {
     fn from(value: &Value) -> Self {
         let mut output = vec![];
         for data in value.post_order_iter() {
@@ -1110,7 +1111,7 @@ impl<'a> Destructor<'a> {
     }
 }
 
-impl<'a> TreeLike for Destructor<'a> {
+impl TreeLike for Destructor<'_> {
     fn as_node(&self) -> Tree<Self> {
         let (value, ty) = match self {
             Self::Ok { value, ty } => (value, ty),