Fix type alias #102
Merged
Fix type alias #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jet_verify -> assert!
I forgot to enforce the semicolon at the end of each type alias. This meant that type aliases only parsed without semicolon, which is not the intended behavior. This commit adds a unit test to assert that type aliases can be parsed as expected. Adding semicolons also makes one fuzz regression obsolete.
uncomputable
force-pushed
the
2024-12-fix-type-alias
branch
from
21f2400 to
4a18efe
Compare
|
Thank you, fuzz test, for catching a violated invariant. |
error: you seem to be trying to use `match` for an equality check. Consider using `if`
--> src/value.rs:446:46
|
446 | ValueInner::UInt(integer) => match print_hex_byte_array {
| ______________________________________________^
447 | | false => write!(f, "{integer}")?,
448 | | true => {} // bytes have already been printed
449 | | },
| |_________________^ help: try: `if print_hex_byte_array == false { write!(f, "{integer}")? }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `-D clippy::single-match` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::single_match)]`
error: could not compile `simfony` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `simfony` (lib test) due to 1 previous errorI'm gonna disable clippy on my end for now -- but we should pin our nightly version of rust here! |
uncomputable
added a commit
to uncomputable/simfony
that referenced
this pull request
Dec 12, 2024
Introduce a new wrapper type, AliasName, for strings that are valid alias names. This makes sure that alias names are correctly sampled by the Arbitrary trait. Fixes BlockstreamResearch#102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type aliases didn't parse as expected. This PR fixes that.