Fix asymptotics of BasePattern #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can be rebased now. CI failure is "real" (cargo fmt). Nice! |
uncomputable
force-pushed
the
2024-08-fix-asymptotics
branch
2 times, most recently
from
b67a5d3 to
25f8109
Compare
|
Rebased |
apoelstra
reviewed
Aug 26, 2024
| @@ -206,40 +206,31 @@ impl BasePattern { | |||
| } | |||
| } | |||
|
|
|||
| /// Check if the `identifier` is contained inside the pattern. | |||
| pub fn contains(&self, identifier: &Identifier) -> bool { | |||
There was a problem hiding this comment.
In 25f8109:
Might as well keep this method, though it can just be a oneliner self.get(identifier).is_some().
|
In 25f8109: The commit messages says the existing method was |
Improve the asymptotics of BasePattern::get and of BasePattern::contains_all to O(n).
uncomputable
force-pushed
the
2024-08-fix-asymptotics
branch
from
25f8109 to
8f3c948
Compare
|
Addressed the comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #80 (because of the inference context parameters)
Fixes #39 Fixes #40