Update simplicity #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we decided to type-check every Simplicity value, we also need to type-check every Simfony value. This produces quite a large diff, although most changes are mechanical. The implementations of From<Option<Self>> and From<Either<Self, Self>> no longer work for Value because additional type information is needed. TypedValue is subsumed by Value. The implementation of Arbitrary for Value needs to be rewritten. Typed values allow us to generate arbitrary well-formed values, which was previously not the case. In the implementation of Arbitrary, first a random type is generated and then a random value of this type. There will be a function such as `Value::arbitrary_of_type`. The details depend on how arbitrary values are going to be used, and they are not used at the moment, so I simply removed the implementation of Arbitrary for Value here. To reduce the diff, the update of rust-simplicity happens in the next commit. For now, the Simplicity values are kept typeness.
uncomputable
force-pushed
the
2024-08-update-sim
branch
from
9374196 to
c106837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rust-simplicity to the latest version. Type-check every Simfony value.