Fix bitcoind tests #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude bitcoind-tests from main workspace. Update dependencies. Update list of tested programs. Most programs cannot yet be tested because they require signatures that need to be dynamically generated during the test.
These files don't do anything.
nix develop .#elements
Don't run the integration tests because this requires a custom build of elementsd, which will take very long to compile. There is currently no cached version of elementsd that we can use. Nevertheless, building the integration tests ensures that their subcrate keeps running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revive the bitcoind-tests sub crate for integration tests. Make it compile and check that it builds in CI to prevent future breaks. Integrate elementsd derivation in the nix flake.
This derivation takes a long time to build because it compiles elementsd from scratch. Once the derivation is built, it is cached, but I don't think we can use it for CI. Until we have some sort of caching, we have to run the integration tests locally. In any case, there is barely any integration test at the moment. I will add more tests once I can generate the witness data for them.