QoL #85
Merged
QoL #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more Value::from(UIntValue::from(n)) business
|
dc60cee fails to build but code-review-ack 8d93f95. |
This enables hex literals for all [u8; N] Simfony types. Adapt the examples to write digital signatures in this way, which is more comfortable than writing Rust-type arrays of hex bytes.
This error is like ExpressionTypeMismatch, but it doesn't know the type of the observed expression. We use ExpressionTypeMismatch as often as we can, and we use ExpressionUnexpectedType in cases where it is hard to determine the observed type.
We no longer need it. An empty JSON file is kind of useless.
It turns out that the parser for ResolvedType that I wrote accepts builtin aliases. This makes witness json files more readable.
uncomputable
force-pushed
the
2024-09-qol
branch
from
8d93f95 to
c5134d1
Compare
|
I messed up during rebasing when I changed the order of commits. I wonder if we can include this check in CI... |
|
We could try this, but it's a bit of a PITA to get the list of commits in CI, and it'd take a long time to test every single commit (especially on 9-commit PRs like this). |
|
Alternately you could always run |
|
@apoelstra Is the rest of the PR ok? |
|
@uncomputable yes |
|
I merged the PR without ACK 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some quality-of-life improvements. In particular, hex strings for arbitrary byte arrays, more constructors, and builtin aliases in witness json files.