Fix WASM #99
Merged
Fix WASM #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncomputable
force-pushed
the
2024-10-fix-wasm
branch
from
aca2ec5 to
06b7641
Compare
|
Fixed how the value of |
uncomputable
added a commit
to uncomputable/simfony-webide
that referenced
this pull request
Oct 20, 2024
Patch secp256k1-zkp to work in WASM. Use my local branch until BlockstreamResearch/simfony#99 is merged.
|
My local CI cannot handle patches in Cargo.toml. Can you just PR to rust-secp-zkp to do a new minor release? |
The CMR used in debug symbols was a hash of the literal span of the affected function call expression. It turns out that the spans from the PEST library differ on x86 and WASM. This resulted in entirely different debug symbols and entirely different root CMRs of programs with debug symbols. To fix this, we assign each span an index. Instead of hashing the span, we hash its index. Because the PEST parser maintains identity and order of spans on all architectures, the resulting debug symbols are the same on all architectures.
The debug symbol for `dbg!(x)` used the span of `x`. If `x` was an expression with its own debug symbol, then there would be a conflict. For example, `dbg!(jet::bip_0340_verify(...))` would have one debug symbol instead of two. An easy fix is to use the whole span of `dbg!(x)` for its debug symbol. We have to trim the `dbg!(` prefix and `)` suffix for the text of the debug symbol.
uncomputable
force-pushed
the
2024-10-fix-wasm
branch
from
06b7641 to
7c91cab
Compare
|
Updated this PR to use the latest version of rust-secp256k1-sys. Remove the Cargo.toml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate was broken on WASM; make it compile again. Check WASM compilation in CI. Fix broken debug symbols on WASM.