As per discussion #337, the default of cparams.splitmode is now AUTO_…

…SPLIT. See #338 though.
Blosc · Nov 29, 2024 · 88d76e9 · 88d76e9
1 parent 08699bb
commit 88d76e9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/blosc2/storage.py b/src/blosc2/storage.py
@@ -59,7 +59,7 @@ class CParams:
         blosc2 will choose the size automatically.
     splitmode: :class:`SplitMode`
         The split mode for the blocks.
-        The default value is :py:obj:`SplitMode.ALWAYS_SPLIT <SplitMode>`.
+        The default value is :py:obj:`SplitMode.AUTO_SPLIT <SplitMode>`.
     filters: :class:`Filter` or int list
         The sequence of filters. Default: [:py:obj:`Filter.NOFILTER <Filter>`,
         :py:obj:`Filter.NOFILTER <Filter>`, :py:obj:`Filter.NOFILTER <Filter>`, :py:obj:`Filter.NOFILTER <Filter>`,
@@ -77,7 +77,7 @@ class CParams:
     typesize: int = 8
     nthreads: int = field(default_factory=default_nthreads)
     blocksize: int = 0
-    splitmode: blosc2.SplitMode = blosc2.SplitMode.ALWAYS_SPLIT
+    splitmode: blosc2.SplitMode = blosc2.SplitMode.AUTO_SPLIT
     filters: list[blosc2.Filter | int] = field(default_factory=default_filters)
     filters_meta: list[int] = field(default_factory=default_filters_meta)
     tuner: blosc2.Tuner = blosc2.Tuner.STUNE

diff --git a/tests/ndarray/test_lossy.py b/tests/ndarray/test_lossy.py
@@ -25,9 +25,10 @@
             False,
         ),
         (
+            # For some reason, ZFP needs to always split buffers in this test
             (100, 1230),
             np.float64,
-            {"codec": blosc2.Codec.ZFP_ACC, "codec_meta": 37},
+            {"codec": blosc2.Codec.ZFP_ACC, "codec_meta": 37, "splitmode": blosc2.SplitMode.ALWAYS_SPLIT},
             None,
             False,
         ),
@@ -39,9 +40,10 @@
             True,
         ),
         (
+            # For some reason, ZFP needs to always split buffers in this test
             (80, 51, 60),
             np.float32,
-            {"codec": blosc2.Codec.ZFP_RATE, "codec_meta": 37},
+            {"codec": blosc2.Codec.ZFP_RATE, "codec_meta": 37, "splitmode": blosc2.SplitMode.ALWAYS_SPLIT},
             "lossy.b2nd",
             False,
         ),

diff --git a/tests/test_storage.py b/tests/test_storage.py
@@ -124,7 +124,7 @@ def test_cparams_defaults():
     cparams = blosc2.CParams()
     assert cparams.codec == blosc2.Codec.ZSTD
     assert cparams.codec_meta == 0
-    assert cparams.splitmode == blosc2.SplitMode.ALWAYS_SPLIT
+    assert cparams.splitmode == blosc2.SplitMode.AUTO_SPLIT
     assert cparams.clevel == 1
     assert cparams.typesize == 8
     assert cparams.nthreads == blosc2.nthreads